Skip to content

Conversation

@gkorland
Copy link
Contributor

@gkorland gkorland commented Sep 6, 2020

No description provided.

@gkorland gkorland requested review from ashtul and rafie September 6, 2020 00:19
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          12       12           
  Lines        1579     1579           
=======================================
  Hits         1395     1395           
  Misses        184      184           
Impacted Files Coverage Δ
test/test.py 95.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e75bf...1e8e1d4. Read the comment docs.

@ashtul
Copy link
Contributor

ashtul commented Sep 6, 2020

@rafie is the the failure related to the redis version?

@gkorland
Copy link
Contributor Author

gkorland commented Sep 6, 2020

@ashtul it's because we changed the redisearch-py client to not support Async

@ashtul ashtul merged commit 1873733 into master Sep 7, 2020
@ashtul ashtul mentioned this pull request Sep 7, 2020
@alancleary
Copy link

@ashtul it's because we changed the redisearch-py client to not support Async

Just came across this when looking for a RediSearch AIO client. Is there a plan to support Async in the future?

@ashtul ashtul deleted the fix_test_async branch October 6, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants