Skip to content

Conversation

@alonre24
Copy link
Collaborator

This include copying the blob when creating batch iterator (as currently we were relying on external buffer that may change).
Unit tests for Cosine were added to both indexes.

@alonre24 alonre24 requested review from DvirDukhan and GuyAv46 March 10, 2022 09:01
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #144 (a0fd9c1) into main (b341bb7) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   92.29%   92.63%   +0.34%     
==========================================
  Files          39       39              
  Lines        1959     1969      +10     
==========================================
+ Hits         1808     1824      +16     
+ Misses        151      145       -6     
Impacted Files Coverage Δ
.../VecSim/algorithms/brute_force/bf_batch_iterator.h 100.00% <ø> (ø)
src/VecSim/algorithms/brute_force/brute_force.h 100.00% <ø> (ø)
src/VecSim/algorithms/hnsw/hnsw_batch_iterator.h 100.00% <ø> (ø)
src/VecSim/algorithms/hnsw/hnsw_wrapper.h 100.00% <ø> (ø)
src/VecSim/vec_sim_index.h 100.00% <ø> (ø)
...ecSim/algorithms/brute_force/bf_batch_iterator.cpp 100.00% <100.00%> (ø)
src/VecSim/algorithms/brute_force/brute_force.cpp 99.47% <100.00%> (+1.63%) ⬆️
src/VecSim/algorithms/hnsw/hnsw_batch_iterator.cpp 100.00% <100.00%> (ø)
src/VecSim/algorithms/hnsw/hnsw_wrapper.cpp 97.02% <100.00%> (+1.93%) ⬆️
src/VecSim/batch_iterator.h 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b341bb7...a0fd9c1. Read the comment docs.

Copy link
Collaborator

@GuyAv46 GuyAv46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alonre24 alonre24 merged commit 0fdca34 into main Mar 10, 2022
@alonre24 alonre24 deleted the normalize_query_vector_in_batch_search_cosine branch March 10, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants