Skip to content

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Mar 10, 2022

exported normalization function and removed normalization step from getDistanceFrom function

@GuyAv46 GuyAv46 requested review from DvirDukhan and alonre24 March 10, 2022 11:50
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #145 (f69bb0f) into main (0fdca34) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   92.63%   92.60%   -0.03%     
==========================================
  Files          39       39              
  Lines        1969     1962       -7     
==========================================
- Hits         1824     1817       -7     
  Misses        145      145              
Impacted Files Coverage Δ
src/VecSim/algorithms/brute_force/brute_force.cpp 99.45% <ø> (-0.02%) ⬇️
src/VecSim/algorithms/hnsw/hnsw_wrapper.cpp 96.93% <ø> (-0.10%) ⬇️
src/VecSim/vec_sim_index.h 100.00% <ø> (ø)
src/VecSim/vec_sim.cpp 92.00% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fdca34...f69bb0f. Read the comment docs.

alonre24
alonre24 previously approved these changes Mar 10, 2022
Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better and cleaner... nice job!

@GuyAv46 GuyAv46 merged commit 8cbf10a into main Mar 10, 2022
@GuyAv46 GuyAv46 deleted the vecsim_normalize branch March 10, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants