Tiered index info MOD-4315 #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAv46
reviewed
May 7, 2023
Collaborator
GuyAv46
left a comment
GuyAv46
left a comment
There was a problem hiding this comment.
General comment:
How does the memory is being reported in tiered? 3 parts? Or is there also the sum of the parts?
| while (VecSimInfoIterator_HasNextField(infoIter)) { | ||
| VecSim_InfoField *infoFiled = VecSimInfoIterator_NextField(infoIter); | ||
| if (!strcmp(infoFiled->fieldName, VecSimCommonStrings::ALGORITHM_STRING)) { | ||
| VecSim_InfoField *infoField = VecSimInfoIterator_NextField(infoIter); |
Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
GuyAv46
approved these changes
May 7, 2023
alonre24
reviewed
May 7, 2023
| info.tieredInfo.frontendCommonInfo = frontendInfo.commonInfo; | ||
| info.tieredInfo.bfInfo = frontendInfo.bfInfo; | ||
|
|
||
| info.tieredInfo.backgroundIndexing = this->frontendIndex->indexSize() > 0; |
Collaborator
There was a problem hiding this comment.
I think we should expose the number of zombies in the tiered index info section as well (num marked deleted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This PR implements the
infoandinfoIteratorcapabilities for tiered indexWhich issues this PR fixes
MOD-4967
Main objects this PR modified
VecSimIndexInfonow containscommonInfosection and each specilized index holds its own specielized info.Mark if applicable