Skip to content

[0.8] [MOD-7297] Replace Variable Length Array on stack with heap allocation #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2024
Merged

[0.8] [MOD-7297] Replace Variable Length Array on stack with heap allocation #508

merged 1 commit into from
Jul 16, 2024

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jul 16, 2024

Description

Backport of #505 to 0.8.

@meiravgri @github-actions
[MOD-7297] Replace Variable Length Array on stack with heap allocation (
aca531c 
#505)

* vaseline for BM

* fix to baseline

* replace stack with allocation

* use unique ptr

* revert format batch iterator

* fix lifetime

* fix

* fix

* fix

* rearrange

* use ref to allocator instead of pointer

* disable flow temp

(cherry picked from commit ab96a8d)
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
Merged
2 tasks
@GuyAv46 GuyAv46 marked this pull request as draft July 16, 2024 05:43
@GuyAv46 GuyAv46 marked this pull request as ready for review July 16, 2024 05:43
@GuyAv46 GuyAv46 requested a review from meiravgri July 16, 2024 05:43
@meiravgri meiravgri merged commit fadfd5f into 0.8 Jul 16, 2024
@meiravgri meiravgri deleted the backport-505-to-0.8 branch July 16, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meiravgri meiravgri meiravgri approved these changes

Assignees

No one assigned

Labels

benchmarks-all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meiravgri