Relax lastReservedThreads assertion in async mode to prevent test flakiness
#816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiravgri
changed the title
lastReservedThreads assertion in async mode to prevent test flakiness
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 126 126
Lines 7368 7368
=======================================
Hits 7149 7149
Misses 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Oct 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax lastReservedThreads assertion in async mode to prevent test flakiness
In async mode, the SVS index may reserve fewer threads than requested for indexing jobs when threads fail to mark themselves as reserved before the reservation timeout expires.
This PR changes the strict equality assertion for
lastReservedThreadsin async mode tests to use less-than-or-equal comparison (ASSERT_LE) instead of exact equality (ASSERT_EQ).