Skip to content

[8.2] Relax lastReservedThreads assertion in async mode to prevent test flakiness #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

[8.2] Relax lastReservedThreads assertion in async mode to prevent test flakiness #817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/test_svs_tiered.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ TYPED_TEST(SVSTieredIndexTest, TestDebugInfoThreadCount) {
// Verify: numThreads unchanged, lastReservedThreads reflects actual availability
backendIndexInfo = tiered_index->GetBackendIndex()->debugInfo();
ASSERT_EQ(backendIndexInfo.svsInfo.numThreads, num_threads);
ASSERT_EQ(backendIndexInfo.svsInfo.lastReservedThreads, num_threads - 1);
ASSERT_LE(backendIndexInfo.svsInfo.lastReservedThreads, num_threads - 1);

// Release occupied thread and trigger another background indexing
thread_wait = false;
Expand All @@ -341,7 +341,7 @@ TYPED_TEST(SVSTieredIndexTest, TestDebugInfoThreadCount) {
// Verify: numThreads unchanged, lastReservedThreads reflects we used all configured threads
backendIndexInfo = tiered_index->GetBackendIndex()->debugInfo();
ASSERT_EQ(backendIndexInfo.svsInfo.numThreads, num_threads);
ASSERT_EQ(backendIndexInfo.svsInfo.lastReservedThreads, num_threads);
ASSERT_LE(backendIndexInfo.svsInfo.lastReservedThreads, num_threads);
}

TYPED_TEST(SVSTieredIndexTest, TestDebugInfoThreadCountWriteInPlace) {
Expand Down
Loading