Initial support for RedisGraph 1.0.0 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
suggested changes
Aug 7, 2018
| ResultSet result = api.query("CREATE ({name:\"roi\",age:32})"); | ||
| Assert.assertFalse(result.hasNext()); | ||
|
|
||
| Assert.assertEquals("1", result.getStatistics().getStringValue(Label.NODES_CREATED)); |
Contributor
There was a problem hiding this comment.
Can we do result.getStatistics().nodesCreated() ?
| ResultSet createResult2 = api.query("CREATE (:person{name:'amit',age:30})"); | ||
|
|
||
| // Connect source and destination nodes. | ||
| ResultSet matchResult = api.query("MATCH (a:person), (b:person) WHERE (a.name = 'roi' AND b.name='amit') CREATE (a)-[knows]->(a)"); |
Contributor
There was a problem hiding this comment.
Rename matchResult, maybe resultset ?
Contributor
Author
There was a problem hiding this comment.
It's just following the rest of the results sets naming according to the query running
| ResultSet create2Result = api.query("CREATE (:qhuman{name:'amit',age:30})"); | ||
|
|
||
| // Connect source and destination nodes. | ||
| ResultSet connectResult= api.query("MATCH (a:qhuman), (b:qhuman) WHERE (a.name = 'roi' AND b.name='amit') CREATE (a)-[knows]->(b)"); |
Contributor
There was a problem hiding this comment.
what's a qhuman, can't we simply use human?
Contributor
Author
There was a problem hiding this comment.
I followed the original tests, and since we don't really have Graph drop implementation I want to use different keys
| Assert.assertNotNull(resultSet.getStatistics().getStringValue(Label.QUERY_INTERNAL_EXECUTION_TIME)); | ||
|
|
||
| Record record = resultSet.next(); | ||
| Assert.assertEquals( "roi", record.getString(1)); |
Contributor
There was a problem hiding this comment.
Can't assume order, position 1 for name, position 0 for age,
unless you specify the order of return attributes.
Use getString("name") and getString("age")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.