New resultset structure #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List<String>, ResultSet size, added scalar types
as well as new interface modifications
access initialized instance. Added call procedure method, and calls to get graph labels, property names, and relationship types.
gkorland
suggested changes
May 7, 2019
| * @return a result set | ||
| */ | ||
| public ResultSet query(String query, Object ...args) { | ||
| StringBuilder sb = new StringBuilder(); |
Contributor
|
@DvirDukhan notice some of the tests failed on CI |
gkorland
reviewed
May 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
===========================================
- Coverage 94.91% 65.25% -29.67%
===========================================
Files 6 16 +10
Lines 118 400 +282
Branches 17 68 +51
===========================================
+ Hits 112 261 +149
- Misses 1 113 +112
- Partials 5 26 +21
Continue to review full report at Codecov.
|
gkorland
suggested changes
May 16, 2019
| * @param graphId a graph to perform the query on | ||
| * @param procedure - procedure to execute | ||
| * @param args - procedure arguments | ||
| * @param kwargs |
src/main/java/com/redislabs/redisgraph/impl/GraphCacheList.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redislabs/redisgraph/impl/GraphCacheList.java
Outdated
Show resolved
Hide resolved
| */ | ||
| private void getProcedureInfo() { | ||
| ResultSet resultSet = redisGraph.callProcedure(graphId, procedure); | ||
| this.clear(); |
Contributor
There was a problem hiding this comment.
Why clear? shouldn't we just add?
src/main/java/com/redislabs/redisgraph/impl/StatisticsImpl.java
Outdated
Show resolved
Hide resolved
gkorland
reviewed
May 16, 2019
| * @param index index of data item | ||
| * @return The string value of the specific procedure response, at the given index. | ||
| */ | ||
| public String getCachedData(int index) { |
Contributor
There was a problem hiding this comment.
It looks good, but just an idea...
public String getCachedData(int index) {
String s;
try {
s = data.get(index);
} catch (IndexOutOfBoundsException e){
synchronized (mutex){
if (index >= data.size()) {
getProcedureInfo();
}
}
s = data.get(index);
}
return s;
}
gkorland
previously approved these changes
May 16, 2019
…ph/JRedisGraph into new-resultset-structure
gkorland
previously approved these changes
May 16, 2019
gkorland
previously approved these changes
May 19, 2019
gkorland
previously approved these changes
May 28, 2019
gkorland
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
Modified to new resultset structure
version moved to 2.0.0-snapshot