Move graph entities #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 68% 68.32% +0.32%
==========================================
Files 16 16
Lines 400 401 +1
Branches 68 68
==========================================
+ Hits 272 274 +2
+ Misses 103 102 -1
Partials 25 25
Continue to review full report at Codecov.
|
added 3 commits
June 12, 2019 08:34
gkorland
reviewed
Jun 12, 2019
| import com.redislabs.redisgraph.impl.Edge; | ||
| import com.redislabs.redisgraph.impl.Node; | ||
| import com.redislabs.redisgraph.impl.Property; | ||
| import com.redislabs.redisgraph.graph_entities.Edge; |
Contributor
There was a problem hiding this comment.
why graph_entities? and not graphEntities?
gkorland
reviewed
Jun 12, 2019
| package com.redislabs.redisgraph; | ||
|
|
||
| import com.redislabs.redisgraph.impl.GraphCache; | ||
| import com.redislabs.redisgraph.impl.graph_cache.GraphCache; |
Contributor
There was a problem hiding this comment.
graph_cache or graphCache
gkorland
suggested changes
Jun 12, 2019
Contributor
gkorland
left a comment
gkorland
left a comment
There was a problem hiding this comment.
Please use Camel case for package names
gkorland
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.