added path support #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkorland
reviewed
Oct 31, 2019
|
|
||
| @Override | ||
| public String toString() { | ||
| final StringBuilder sb = new StringBuilder("Path{"); |
Contributor
There was a problem hiding this comment.
return "Path{nodes=" + nodes + " edges=" + edges + "}";
Contributor
Author
There was a problem hiding this comment.
auto-generated. I like string builder better than string appends.
| public class RedisGraphAPITest { | ||
|
|
||
| private class PathBuilder{ | ||
| List<Node> nodes; |
Contributor
Author
There was a problem hiding this comment.
Path builder is now under test.tuils
gkorland
previously approved these changes
Oct 31, 2019
gkorland
approved these changes
Nov 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 75.86% 77.77% +1.91%
==========================================
Files 22 23 +1
Lines 493 522 +29
Branches 75 79 +4
==========================================
+ Hits 374 406 +32
Misses 90 90
+ Partials 29 26 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added path support
added equalsverifier for hashCode and equals functions verifications