Skip to content

Conversation

@DvirDukhan
Copy link
Contributor

No description provided.

@DvirDukhan DvirDukhan requested a review from gkorland November 20, 2019 13:06
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #54 into master will increase coverage by 1.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   77.77%   78.87%   +1.09%     
==========================================
  Files          23       23              
  Lines         522      549      +27     
  Branches       79       84       +5     
==========================================
+ Hits          406      433      +27     
  Misses         90       90              
  Partials       26       26
Impacted Files Coverage Δ
...islabs/redisgraph/impl/api/AbstractRedisGraph.java 90% <100%> (+4.28%) ⬆️
...main/java/com/redislabs/redisgraph/impl/Utils.java 92.06% <100%> (+4.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef0b2c...59a6a98. Read the comment docs.

@gkorland
Copy link
Contributor

@DvirDukhan please add negative tests too, like missing params or unused params

@DvirDukhan DvirDukhan merged commit a2b4202 into master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants