Skip to content

Conversation

@DvirDukhan
Copy link
Contributor

No description provided.

@DvirDukhan DvirDukhan requested a review from gkorland December 12, 2019 07:15
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #56 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   78.87%   78.94%   +0.07%     
==========================================
  Files          23       23              
  Lines         549      551       +2     
  Branches       84       84              
==========================================
+ Hits          433      435       +2     
  Misses         90       90              
  Partials       26       26
Impacted Files Coverage Δ
...main/java/com/redislabs/redisgraph/Statistics.java 88.23% <100%> (+0.73%) ⬆️
...labs/redisgraph/impl/resultset/StatisticsImpl.java 65.71% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b4202...964ba5c. Read the comment docs.

Copy link
Contributor

@gkorland gkorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you calling Removed and Remove and not using the same terms as RedisGraph, Delete?

@DvirDukhan DvirDukhan merged commit 2655359 into master Dec 15, 2019
@DvirDukhan DvirDukhan deleted the comply_to_1.99.7_index_response branch December 15, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants