Add Optional test, remove invalid assertions from tests #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

DvirDukhan merged 2 commits into master from optional-test-updates

Apr 7, 2020

Contributor

jeffreylovitz commented Apr 6, 2020

No description provided.


          Add Optional test, remove invalid assertions from tests

1da712b

jeffreylovitz requested a review from DvirDukhan

April 6, 2020 19:55

jeffreylovitz self-assigned this

codecov bot commented Apr 6, 2020 •

edited

Loading

Codecov Report

Merging #70 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     78.44%   77.89%   -0.55%     
+ Complexity      180      179       -1     
============================================
  Files            23       23              
  Lines           552      552              
  Branches         60       60              
============================================
- Hits            433      430       -3     
- Misses           93       96       +3     
  Partials         26       26

Impacted Files	Coverage Δ	Complexity Δ
...slabs/redisgraph/impl/resultset/ResultSetImpl.java	`78.89% <0.00%> (-3.67%)`	`35.00% <0.00%> (-2.00%)`
...edislabs/redisgraph/impl/resultset/RecordImpl.java	`50.00% <0.00%> (+4.54%)`	`8.00% <0.00%> (+1.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2576ce8...0616a30. Read the comment docs.

DvirDukhan requested changes

View reviewed changes

src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java

Comment on lines -196 to -198

    
                      Assert.assertEquals(COLUMN_NODE, schemaTypes.get(0));

                      Assert.assertEquals(COLUMN_RELATION, schemaTypes.get(1));

                      Assert.assertEquals(COLUMN_SCALAR, schemaTypes.get(2));

Contributor

DvirDukhan Apr 7, 2020

remove line 184
please annotate getSchemaTypes as @deprecated both in the interface and the implemented class, with explenation why it is deprecated

src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java

Comment on lines -379 to -381

    
                          Assert.assertEquals(COLUMN_NODE, schemaTypes.get(0));

                          Assert.assertEquals(COLUMN_RELATION, schemaTypes.get(1));

                          Assert.assertEquals(COLUMN_SCALAR, schemaTypes.get(2));

Contributor

DvirDukhan Apr 7, 2020

remove line 368 and all other lines using schemaTypes

src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java

Comment on lines -423 to -424

    
                          Assert.assertEquals(COLUMN_NODE, schemaTypes.get(0));

                          Assert.assertEquals(COLUMN_RELATION, schemaTypes.get(1));

Contributor

DvirDukhan Apr 7, 2020

remove line 410 and all the lines using schema types

src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java

Comment on lines -472 to -473

    
                      Assert.assertEquals(COLUMN_NODE, schemaTypes.get(0));

                      Assert.assertEquals(COLUMN_RELATION, schemaTypes.get(1));

Contributor

DvirDukhan Apr 7, 2020

remove line 457 and all line using schemaTypes

src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java

Comment on lines -507 to -508

    
                      Assert.assertEquals(COLUMN_NODE, schemaTypes.get(0));

                      Assert.assertEquals(COLUMN_RELATION, schemaTypes.get(1));

Contributor

DvirDukhan Apr 7, 2020

remove line 490 and all lines using schemaTypes

src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java

Comment on lines -585 to -586

		Assert.assertEquals(COLUMN_NODE, schemaTypes.get(0));

Contributor

DvirDukhan Apr 7, 2020

remove line 563 and all lines using schemaTypes


          Remove test accesses to getSchemaTypes API

0616a30

DvirDukhan approved these changes

View reviewed changes

DvirDukhan merged commit 4745ab6 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet