Few code cleanups #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
============================================
+ Coverage 77.77% 78.67% +0.89%
- Complexity 183 187 +4
============================================
Files 23 23
Lines 558 558
Branches 61 61
============================================
+ Hits 434 439 +5
+ Misses 98 93 -5
Partials 26 26
Continue to review full report at Codecov.
|
gkorland
commented
Jul 29, 2020
| Assert.assertEquals("HeaderImpl{" | ||
| + "schemaTypes=[COLUMN_SCALAR, COLUMN_SCALAR, COLUMN_SCALAR], " | ||
| + "schemaNames=[a, r, a.age]}", header.toString()); | ||
| // Assert.assertEquals(-1901778507, header.hashCode()); |
Contributor
Author
There was a problem hiding this comment.
@DvirDukhan something is strange about the HeaderImpl.hashCode(), it's not deterministic, on each run the value is different despite the fact that the values are the same
DvirDukhan
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.