Skip to content

added path support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2019
Merged

added path support #25

merged 4 commits into from
Nov 5, 2019

Conversation

@DvirDukhan
Copy link
Contributor

@DvirDukhan DvirDukhan commented Oct 31, 2019

added path support
add deepequal dependency https://www.npmjs.com/package/deep-equal for easier comparisons.

@DvirDukhan DvirDukhan requested a review from gkorland October 31, 2019 13:34
gkorland
gkorland suggested changes Oct 31, 2019
View reviewed changes
test/pathBuilder.js Outdated
@@ -0,0 +1,35 @@
Node = require("../src/node");
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

const Node = require("../src/node"),
          Edge = require("../src/edge"),
          Path = require("../src/path");

test/pathBuilder.js Outdated
@@ -0,0 +1,35 @@
Node = require("../src/node");
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node = require("../src/node"),
Edge = require("../src/edge"),
Path = require("../src/path");

Copy link
Contributor Author

@DvirDukhan DvirDukhan Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where?

test/pathBuilder.js Outdated
@@ -0,0 +1,35 @@
Node = require("../src/node");
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const Statistics = require("./statistics"),
Record = require("./record"),
Node = require("./node"),
Edge = require("./edge"),
Path = require("./path"),
ReplyError = require("redis").ReplyError;

test/redisGraphAPITest.js Outdated
redis = require("redis"),
Label = require("../src/label"),
RedisGraph = require("../src/graph");
PathBuilder = require("./pathBuilder");
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here ...

Copy link
Contributor Author

@DvirDukhan DvirDukhan Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where?

src/path.js
return this.edges;
}

getNode(index){
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you use gettter/setter?

Copy link
Contributor Author

@DvirDukhan DvirDukhan Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please elaborate

Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get

Copy link
Contributor Author

@DvirDukhan DvirDukhan Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a property getter, so done, for every zero parametes function

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #25 into master will decrease coverage by 3.57%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   93.67%   90.09%   -3.58%     
==========================================
  Files           5        6       +1     
  Lines          79      101      +22     
  Branches        6        6              
==========================================
+ Hits           74       91      +17     
- Misses          5       10       +5
Impacted Files Coverage Δ
src/statistics.js 100% <ø> (ø) ⬆️
src/edge.js 81.81% <ø> (ø) ⬆️
src/node.js 77.77% <ø> (ø) ⬆️
src/label.js 100% <ø> (ø) ⬆️
src/record.js 100% <ø> (+4.16%) ⬆️
src/path.js 72.72% <72.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eda4c4...0f2f9ba. Read the comment docs.

gkorland
gkorland suggested changes Nov 4, 2019
View reviewed changes
src/resultSet.js Outdated
Record = require("./record");
Node = require("./node");
Edge = require("./edge");
Path = require("./path");
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

test/pathBuilder.js Outdated
@@ -0,0 +1,35 @@
Node = require("../src/node");
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where?

test/redisGraphAPITest.js Outdated
redis = require("redis"),
Label = require("../src/label"),
RedisGraph = require("../src/graph");
PathBuilder = require("./pathBuilder");
Copy link
Contributor

@gkorland gkorland Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where?

src/path.js
this.edges = edges;
}

get Nodes(){
Copy link
Contributor

@gkorland gkorland Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DvirDukhan capital letter?

Copy link
Contributor Author

@DvirDukhan DvirDukhan Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

test/pathBuilder.js

class PathBuilder {
constructor(nodeCount){
this.nodes = new Array();
Copy link
Contributor

@gkorland gkorland Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

     this.nodes = [];

Copy link
Contributor Author

@DvirDukhan DvirDukhan Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gkorland gkorland merged commit 02418b6 into master Nov 5, 2019
@gkorland gkorland deleted the path_type branch April 5, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gkorland gkorland gkorland approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DvirDukhan @gkorland