Parameters support #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 6 6
Lines 101 101
Branches 6 6
=======================================
Hits 91 91
Misses 10 10Continue to review full report at Codecov.
|
Contributor
|
@DvirDukhan please add negative tests too |
gkorland
suggested changes
Nov 24, 2019
gkorland
suggested changes
Nov 25, 2019
src/graph.js
Outdated
| for(var i = 0; i < paramValue.length; i++) { | ||
| stringsArr[i] = this.paramToString(paramValue[i]); | ||
| } | ||
| return "[" + stringsArr.join(", ") + "]"; |
Contributor
There was a problem hiding this comment.
Why not avoid this + also
Contributor
There was a problem hiding this comment.
@DvirDukhan sorry my mistake I didn't notice the "," in the join I think your original code is better.
gkorland
approved these changes
Nov 26, 2019
|
Would it be possible to document this in the README? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.