comply to 1.99.7 index mutation reply #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 90.09% 90.47% +0.37%
==========================================
Files 6 6
Lines 101 105 +4
Branches 6 6
==========================================
+ Hits 91 95 +4
Misses 10 10
Continue to review full report at Codecov.
|
DvirDukhan
force-pushed
the
comply_to_1.99.7_index_response
branch
4 times, most recently
from
53c277b to
ccbebf8
Compare
gkorland
suggested changes
Dec 25, 2019
examples/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "redisgraph.js": "^1.2.0" | ||
| "redisgraph.js": "github:RedisGraph/redisgraph.js" |
Contributor
There was a problem hiding this comment.
it might be an issue if someone will copy it, you might want to set a relative path
src/graph.js
Outdated
| * @param port Redis port | ||
| * @param options node_redis options | ||
| * @param {string} graphId the graph id | ||
| * @param {*} host Redis host or node_redis client |
src/graph.js
Outdated
| * @param options node_redis options | ||
| * @param {string} graphId the graph id | ||
| * @param {*} host Redis host or node_redis client | ||
| * @param {*} port Redis port |
Contributor
There was a problem hiding this comment.
why {*} I guess you would like to mark as optional
src/record.js
Outdated
| /** | ||
| * Builds a Record object | ||
| * @constructor | ||
| * @param {*} header |
src/resultSet.js
Outdated
| * A raw representation of a header (query response schema) is a list. | ||
| * Each entry in the list is a tuple (list of size 2). | ||
| * tuple[0] represents the type of the column, and tuple[1] represents the name of the column. | ||
| * @param rawHeader |
src/resultSet.js
Outdated
| // [[name, value, value type] X N] | ||
| /** | ||
| * Parse raw entity properties representation into a Map | ||
| * @param {*} props |
DvirDukhan
force-pushed
the
comply_to_1.99.7_index_response
branch
2 times, most recently
from
6e5d2d2 to
4ebd238
Compare
DvirDukhan
force-pushed
the
comply_to_1.99.7_index_response
branch
from
4ebd238 to
d321ab6
Compare
gkorland
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.