Display the list of RDI instances#2853
Merged
kyle-marcum merged 6 commits intofeature/RI-4616-rdi-supportfrom Dec 15, 2023
Merged
Display the list of RDI instances#2853kyle-marcum merged 6 commits intofeature/RI-4616-rdi-supportfrom
kyle-marcum merged 6 commits intofeature/RI-4616-rdi-supportfrom
Conversation
kyle-marcum
force-pushed
the
fe/feature/RI-5152_rdi-instances
branch
3 times, most recently
from
8d7e84d to
9f0e7d8
Compare
kyle-marcum
force-pushed
the
fe/feature/RI-5152_rdi-instances
branch
from
9f0e7d8 to
be6cc6a
Compare
…e actions for RDI Instances
rsergeenko
reviewed
Dec 13, 2023
| .search { | ||
| &:global(.euiFieldSearch) { | ||
| border: none !important; | ||
| background-color: #171717 !important; |
Contributor
There was a problem hiding this comment.
please, use variable (Check, also, please other places and the light theme)
rsergeenko
reviewed
Dec 13, 2023
| } | ||
|
|
||
| .moreInfoPanel { | ||
| background-color: #2B2B2B !important; |
…d more info panels
…more unit tests for ItemList component
| import { classToClass } from 'src/utils'; | ||
|
|
||
| // mock data | ||
| let mockRdiInstances: Rdi[] = [ |
Contributor
There was a problem hiding this comment.
I guess better remove it. You can use it for development. What do use think ?
Contributor
Author
There was a problem hiding this comment.
I removed the mock here but left the mock request when clicking the Rdi Instance header button to exercise adding RDI Instances so that they also can be deleted.
| * @inheritDoc | ||
| */ | ||
| public async list(): Promise<Rdi[]> { | ||
| const entities = await this.repository |
Contributor
There was a problem hiding this comment.
And restore this part
| * @inheritDoc | ||
| */ | ||
| public async create(rdi: Rdi): Promise<Rdi> { | ||
| const entity = classToClass(RdiEntity, rdi); |
Contributor
There was a problem hiding this comment.
Maybe better do not mock anything?
| public async delete(id: string): Promise<void> { | ||
| await this.repository.delete(id); | ||
| public async delete(ids: string[]): Promise<void> { | ||
| mockRdiInstances = mockRdiInstances.filter((instance) => !ids.includes(instance.id)); |
kyle-marcum
force-pushed
the
fe/feature/RI-5152_rdi-instances
branch
from
9cc2405 to
945719a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.