Skip to content

Conversation

alanroche
Copy link

Add configuration support for open ssl.
Also supports "rediss://" url scheme.

@fe2s fe2s self-requested a review March 23, 2019 11:23
@fe2s
Copy link
Contributor

fe2s commented Mar 24, 2019

Hi Alan,

Thank you for the PR. It looks good.
Did you test it with SSL proxy?
Could you please also update documentation page.
Do you have any instructions or example how to enable Redis SSL with Spark cluster?

@fe2s fe2s mentioned this pull request Apr 8, 2019
@yananielsen
Copy link

shouldn't all Endpoint constructors now contain the ssl parameter as well? i.e
RedisEndpoint(host, port, auth, dbNum, timeout) => RedisEndpoint(host, port, auth, dbNum, timeout, ssl)

@rtyler
Copy link

rtyler commented Apr 27, 2020

This work was superseded and merged as part of #235, so I believe this pull request can be closed now.

@fe2s fe2s closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants