Updates the subscription timeout value for update function to 30 mins #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengesoff
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR adjusts the default optional timeout value for the update function. The original default value was set to 10 minutes and has now been updated to 30 mins to align with the create optional default timeout value.
The original expectation was that most database creations would be actioned at the time of the subscription creation, but this is not completely true. The databases are managed through the subscription life and databases can be added or removed later as required. The following issue showed that the update default timeout value can be too short at 10 minutes: #124
Because database creation can happen in the subscription create and update functions then it make sense to keep them aligned.
As mentioned in the following documentation by HashiCorp Optional Timouts not all resource support the optional timeout configuration, but the susbcription resource does support the HCL block. I the default of 30 minutes for either create or update is not enough then it can be adjusted through this method. Existing documentation for the resource also shows this and the PR will update rediscloud_subscription#timeouts to reflect the new default value.