Skip to content

Update rediscloud_subscription.md #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

Update rediscloud_subscription.md #326

merged 1 commit into from
Feb 1, 2023

Conversation

@noham14
Copy link
Contributor

@noham14 noham14 commented Jan 30, 2023

Please update the AZ selection field description as modified

@noham14
Update rediscloud_subscription.md
e585393 
Please update the AZ selection field description as modified
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@greg-oc greg-oc merged commit 821c6da into RedisLabs:main Feb 1, 2023
byron-oc pushed a commit that referenced this pull request Feb 20, 2023
@noham14 @byron-oc
Update rediscloud_subscription.md (#326)
ef6f72e 
Updates the AZ selection field description
byron-oc added a commit that referenced this pull request Mar 2, 2023
@bengesoff @greg-oc
@pvegh-oc @danielarbiv @noham14 @byron-oc
feat: support new active-active databases (#318)
e922f4c 
* (WIP) Initial AA subscription implementation

* adds aa subscription documentation

* adds acceptance tests

* addresses TODOs

* Updating go client api version

* Removing replace from go.mod

* Fixing AA Subscription Acceptance test

* Removing unneccesary test for average_item_size_in_bytes

* Temporary cloud_account_id fix while oc account is broken

* Active active read initial create

* Active active Region create acceptance test

* Active Active Region update, delete and in dev acceptance test

* Refactoring + fixing state update issue on recreate_region flag change

* AA Database implementation
Squashed commit of the following:

commit ebf043a
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 14:15:05 2022 +0000

    Comment out WIP tests

commit b0ade13
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:42:49 2022 +0000

    fix tf lint issue and remove completed TODOs

commit 9e5d412
Merge: 67d9a9e 4313fe7
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:33:47 2022 +0000

    Merge branch 'aa_database' of github.com:RedisLabs/terraform-provider-rediscloud into aa_database

commit 67d9a9e
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:33:17 2022 +0000

    acceptance test fixes

commit 5c3c9c5
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:30:57 2022 +0000

    documentation fixes

commit d0f3338
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:30:28 2022 +0000

    addresses TFLint issues

commit 4313fe7
Merge: d3c436b 848cfa6
Author: Greg Nuttall <102314841+greg-oc@users.noreply.github.com>
Date:   Tue Dec 20 12:01:47 2022 +0000

    Merge branch 'develop' into aa_database

commit d3c436b
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 11:43:38 2022 +0000

    updates go.mod

commit 030a8e2
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 11:35:06 2022 +0000

    Fixing small TODOs

commit 6085345
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 10:58:16 2022 +0000

    add public and private endpoint attributes

commit 80a87a0
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Fri Dec 16 10:42:46 2022 +0000

    single layer map solution

commit 606a948
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 13:39:01 2022 +0000

    (WIP) AA Database implementation

commit c1bbd18
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 13:31:48 2022 +0000

    updates single region database documentation

commit c26b8e6
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 13:30:34 2022 +0000

    removing secrets workflow

commit 404cc2c
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 11:19:49 2022 +0000

    temporarily add secrets hack

commit 1bbe7f7
Merge: a6a5615 028e163
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 6 09:15:41 2022 +0000

    Merge branch 'aa_database' of github.com:RedisLabs/terraform-provider-rediscloud into aa_database

commit a6a5615
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Mon Dec 5 13:42:52 2022 +0000

    AA Database add create and update functions

commit 028e163
Author: Peter Vegh <peter.vegh@opencredo.com>
Date:   Mon Dec 5 11:23:58 2022 +0000

    Active active Database Acceptance test

commit a716015
Author: Peter Vegh <peter.vegh@opencredo.com>
Date:   Mon Dec 5 10:22:25 2022 +0000

    Adding Active Active Database read Acceptance test

commit 09da797
Author: Peter Vegh <peter.vegh@opencredo.com>
Date:   Mon Dec 5 08:49:02 2022 +0000

    Updating ActiveActiveDatabase documentation

commit f95146d
Merge: 02da20a af4e26e
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 1 16:09:02 2022 +0000

    Merge branch 'aa_subscription' into aa_database

commit 02da20a
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 1 14:26:28 2022 +0000

    (WIP) Initial AA database implementation

commit 16c6a15
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 1 13:12:04 2022 +0000

    add aa database to provider.go

* Review changes + documentation for Regions resource

* fix issue with undefined override_region block

* Enabling scenario back

* Fixing Linting issue

* Updating AWS_CLOUD_ACCOUNT in gihub actions

* Fixing ordering issue of delete and create + a new acceptance to test

* Fixing aa regions acceptance test

* Update terraform_provider.yml

update AWS_TEST_CLOUD_ACCOUNT_NAME

* Fixing AA subscription test checks + increasing git workflow test timeout

* Revert "Temporary cloud_account_id fix while oc account is broken"

This reverts commit 848cfa6.

* Adding wait for db delete

* Active-Active Database (#300)

* add aa database to provider.go

* (WIP) Initial AA database implementation

* Updating ActiveActiveDatabase documentation

* Adding Active Active Database read Acceptance test

* Active active Database Acceptance test

* AA Database add create and update functions

* temporarily add secrets hack

* removing secrets workflow

* updates single region database documentation

* (WIP) AA Database implementation

* single layer map solution

* add public and private endpoint attributes

* Fixing small TODOs

* updates go.mod

* addresses TFLint issues

* documentation fixes

* acceptance test fixes

* fix tf lint issue and remove completed TODOs

* Comment out WIP tests

* add source_ips example to documentation

* fixes failing acceptance tests

* fixing issues discovered through acc tests

* update import documentation

* fix: active-active subscription acceptance test attribute check bug

* fix: subscription acceptance test's import check

Needs to handle the case when the set isn't defined as an equivalent to
the set being empty. This is the same behaviour as the
`resource.TestCheckResourceAttr` check from the SDK.

* upgrade go api client

* chore: change test timeout to 6h instead of 2h

* fix acceptance test

* remove ossClusterApi checks temporarily

* wait for database to be deleted (corrects merge error)

* remove old TODOs

* remove unused import

* Addresses code review comments

Co-authored-by: Peter Vegh <peter.vegh@opencredo.com>
Co-authored-by: Ben Gesoff <ben.gesoff@opencredo.com>

* test: add `CheckDestroy` function for active-active resources (#307)

* test: add `CheckDestroy` function for active-active subscriptions

* chore: fake change to try and trigger CI

* test: add `CheckDestroy` function for active-active regions

* feat: active-active subscription network peering (#313)

* wip: Byron implementation

* wip Ben

* chore: temporarily point to `aa_subscription` branch of Go client

* wip: peering test

* test: use peering resources from envs vars

* ci: update test cloud account name

* test: reenable the `support_oss_cluster_api` test

* chore: update go client dependency

* ci: reset `AWS_TEST_CLOUD_ACCOUNT_NAME`

* test: fix some of the reasons for previous failure

* fix: read `vpc_cidrs` correctly when there's only one CIDR block

* test: ignore global and override attributes while importing AA DB

Not supported by import operation, as stated in documentation. Therefore
must also be omitted when testing.

Co-authored-by: gregnuttall <greg.nuttall@opencredo.com>

* chore: update rediscloud-go-api and add AA test sweepers (#315)

* fix: AA regions bug and some assorted documentation things (#317)

* fix `make build` command

* fix: AA regions not setting resource ID when all regions already exist

* make `support_oss_cluster_api` optional to match docs

* docs: fix AA peering example to use AA subscription

* fix: importing active-active regions failing due to incorrect ID (#319)

* Update rediscloud_active_active_subscription.md

Fixes of documentation - rediscloud_active_active_subscription

* Update rediscloud_active_active_subscription_database.md

Align documentation - rediscloud_active_active_subscription_database resource

* fix: regions inactive subscription error and memory limit hardcoding (#320)

* fix: remove incorrect hardcoding of DB memory limit

* temp: change rediscloud-go-api dependency to branch

* fix: restructure regions resource to always use update logic, fix issue

Also some minor improvements such as code simplifications, and avoiding
the use of the `cmp` package which should only be used in tests as it
can panic instead of error for some conditions.

The create function now calls into the update function so that the logic
is consistent. It also rearranges a lot of the code so it is easier to
follow.

Finally the order of when things get created and deleted are more clear
and the appropriate waits are in place.

There is an outstanding TODO regarding subscription mutexes which I will
seek further clarification on before merging.

* chore: bump regions timeout to 1hr for extra subscription waits

* test: update tests to avoid CIDR clash error

* refactor: make AA subs cloud_provider default to AWS

* fix: move subscription mutex locking to guard actual update operations

* ci: change cloud account name

* chore: remove go.mod `replace` for go-api and upgrade (#329)

* refactor: remove support_oss_cluster_api from subscription creation plan (#330)

* refactor: remove support_oss_cluster_api from subscription creation plan

* test: remove `support_oss_cluster_api` attribute from test resources

* docs: remove `region_id` from active-active regions

* docs: set `region_id` and `vpc_id` as computed for regions resource

* refactor: rename to `database_id`

* refactor: change `vpc_cidrs` to `vpc_cidr` single string attribute

* docs: update peering `vpc_cidr` example

* Update rediscloud_active_active_subscription_database.md

* Update rediscloud_active_active_subscription_database.md

* Update rediscloud_active_active_regions.md (#336)

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

---------

Co-authored-by: Ben Gesoff <ben.gesoff@opencredo.com>

* Update docs/resources/rediscloud_active_active_subscription_database.md

Co-authored-by: Ben Gesoff <ben@gesoff.uk>

* Update rediscloud_active_active_subscription_peering.md (#337)

* Update rediscloud_subscription.md (#314)

Clarification for the users about this field.

* Update rediscloud_subscription.md (#311)

* Update rediscloud_subscription.md

As we are not supporting it for our hosted AWS solution, it may and confuse customers.

* Update rediscloud_subscription.md (#326)

Updates the AZ selection field description

* Update rediscloud_subscription.md (#322)

documentation adjustment

* Update rediscloud_subscription_database.md (#323)

Documentation adjustments

* Update rediscloud_subscription_database.md (#340)

* Update rediscloud_subscription_peering.md (#338)

* Update rediscloud_subscription.md (#339)

* Fixing ordering issue of delete and create + a new acceptance to test

* uncomment failing tests

* remove new line to re-run workflow

* add new line to re-run workflow

* Update rediscloud_active_active_subscription.md (#348)

* Update rediscloud_active_active_subscription_database.md (#345)

* Update rediscloud_active_active_regions.md (#343)

* Update rediscloud_active_active_regions.md (#350)

* Update rediscloud_active_active_subscription.md (#351)

* add the latest redis-go-api tag v0.2.0 to go.mod

---------

Co-authored-by: gregnuttall <greg.nuttall@opencredo.com>
Co-authored-by: Peter Vegh <peter.vegh@opencredo.com>
Co-authored-by: Greg Nuttall <102314841+greg-oc@users.noreply.github.com>
Co-authored-by: pvegh-oc <77333445+pvegh-oc@users.noreply.github.com>
Co-authored-by: danielarbiv <86226145+danielarbiv@users.noreply.github.com>
Co-authored-by: noham14 <45514308+noham14@users.noreply.github.com>
Co-authored-by: byron-oc <byron.oconnor@opencredo.com>
burythehammer pushed a commit that referenced this pull request Nov 10, 2025
@noham14
Update rediscloud_subscription.md (#326)
081f6af 
Updates the AZ selection field description
burythehammer pushed a commit that referenced this pull request Nov 10, 2025
@bengesoff @greg-oc
@pvegh-oc @danielarbiv @noham14 @byron-oc
feat: support new active-active databases (#318)
a66c84d 
* (WIP) Initial AA subscription implementation

* adds aa subscription documentation

* adds acceptance tests

* addresses TODOs

* Updating go client api version

* Removing replace from go.mod

* Fixing AA Subscription Acceptance test

* Removing unneccesary test for average_item_size_in_bytes

* Temporary cloud_account_id fix while oc account is broken

* Active active read initial create

* Active active Region create acceptance test

* Active Active Region update, delete and in dev acceptance test

* Refactoring + fixing state update issue on recreate_region flag change

* AA Database implementation
Squashed commit of the following:

commit ebf043a
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 14:15:05 2022 +0000

    Comment out WIP tests

commit b0ade13
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:42:49 2022 +0000

    fix tf lint issue and remove completed TODOs

commit 9e5d412
Merge: 67d9a9e 4313fe7
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:33:47 2022 +0000

    Merge branch 'aa_database' of github.com:RedisLabs/terraform-provider-rediscloud into aa_database

commit 67d9a9e
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:33:17 2022 +0000

    acceptance test fixes

commit 5c3c9c5
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:30:57 2022 +0000

    documentation fixes

commit d0f3338
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 13:30:28 2022 +0000

    addresses TFLint issues

commit 4313fe7
Merge: d3c436b 237e5a1
Author: Greg Nuttall <102314841+greg-oc@users.noreply.github.com>
Date:   Tue Dec 20 12:01:47 2022 +0000

    Merge branch 'develop' into aa_database

commit d3c436b
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 11:43:38 2022 +0000

    updates go.mod

commit 030a8e2
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 11:35:06 2022 +0000

    Fixing small TODOs

commit 6085345
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 20 10:58:16 2022 +0000

    add public and private endpoint attributes

commit 80a87a0
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Fri Dec 16 10:42:46 2022 +0000

    single layer map solution

commit 606a948
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 13:39:01 2022 +0000

    (WIP) AA Database implementation

commit c1bbd18
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 13:31:48 2022 +0000

    updates single region database documentation

commit c26b8e6
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 13:30:34 2022 +0000

    removing secrets workflow

commit 404cc2c
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 15 11:19:49 2022 +0000

    temporarily add secrets hack

commit 1bbe7f7
Merge: a6a5615 028e163
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Tue Dec 6 09:15:41 2022 +0000

    Merge branch 'aa_database' of github.com:RedisLabs/terraform-provider-rediscloud into aa_database

commit a6a5615
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Mon Dec 5 13:42:52 2022 +0000

    AA Database add create and update functions

commit 028e163
Author: Peter Vegh <peter.vegh@opencredo.com>
Date:   Mon Dec 5 11:23:58 2022 +0000

    Active active Database Acceptance test

commit a716015
Author: Peter Vegh <peter.vegh@opencredo.com>
Date:   Mon Dec 5 10:22:25 2022 +0000

    Adding Active Active Database read Acceptance test

commit 09da797
Author: Peter Vegh <peter.vegh@opencredo.com>
Date:   Mon Dec 5 08:49:02 2022 +0000

    Updating ActiveActiveDatabase documentation

commit f95146d
Merge: 02da20a 05cdf1a
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 1 16:09:02 2022 +0000

    Merge branch 'aa_subscription' into aa_database

commit 02da20a
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 1 14:26:28 2022 +0000

    (WIP) Initial AA database implementation

commit 16c6a15
Author: gregnuttall <greg.nuttall@opencredo.com>
Date:   Thu Dec 1 13:12:04 2022 +0000

    add aa database to provider.go

* Review changes + documentation for Regions resource

* fix issue with undefined override_region block

* Enabling scenario back

* Fixing Linting issue

* Updating AWS_CLOUD_ACCOUNT in gihub actions

* Fixing ordering issue of delete and create + a new acceptance to test

* Fixing aa regions acceptance test

* Update terraform_provider.yml

update AWS_TEST_CLOUD_ACCOUNT_NAME

* Fixing AA subscription test checks + increasing git workflow test timeout

* Revert "Temporary cloud_account_id fix while oc account is broken"

This reverts commit 237e5a1df18bfb94c7d596c2d69ac65120569ad4.

* Adding wait for db delete

* Active-Active Database (#300)

* add aa database to provider.go

* (WIP) Initial AA database implementation

* Updating ActiveActiveDatabase documentation

* Adding Active Active Database read Acceptance test

* Active active Database Acceptance test

* AA Database add create and update functions

* temporarily add secrets hack

* removing secrets workflow

* updates single region database documentation

* (WIP) AA Database implementation

* single layer map solution

* add public and private endpoint attributes

* Fixing small TODOs

* updates go.mod

* addresses TFLint issues

* documentation fixes

* acceptance test fixes

* fix tf lint issue and remove completed TODOs

* Comment out WIP tests

* add source_ips example to documentation

* fixes failing acceptance tests

* fixing issues discovered through acc tests

* update import documentation

* fix: active-active subscription acceptance test attribute check bug

* fix: subscription acceptance test's import check

Needs to handle the case when the set isn't defined as an equivalent to
the set being empty. This is the same behaviour as the
`resource.TestCheckResourceAttr` check from the SDK.

* upgrade go api client

* chore: change test timeout to 6h instead of 2h

* fix acceptance test

* remove ossClusterApi checks temporarily

* wait for database to be deleted (corrects merge error)

* remove old TODOs

* remove unused import

* Addresses code review comments

Co-authored-by: Peter Vegh <peter.vegh@opencredo.com>
Co-authored-by: Ben Gesoff <ben.gesoff@opencredo.com>

* test: add `CheckDestroy` function for active-active resources (#307)

* test: add `CheckDestroy` function for active-active subscriptions

* chore: fake change to try and trigger CI

* test: add `CheckDestroy` function for active-active regions

* feat: active-active subscription network peering (#313)

* wip: Byron implementation

* wip Ben

* chore: temporarily point to `aa_subscription` branch of Go client

* wip: peering test

* test: use peering resources from envs vars

* ci: update test cloud account name

* test: reenable the `support_oss_cluster_api` test

* chore: update go client dependency

* ci: reset `AWS_TEST_CLOUD_ACCOUNT_NAME`

* test: fix some of the reasons for previous failure

* fix: read `vpc_cidrs` correctly when there's only one CIDR block

* test: ignore global and override attributes while importing AA DB

Not supported by import operation, as stated in documentation. Therefore
must also be omitted when testing.

Co-authored-by: gregnuttall <greg.nuttall@opencredo.com>

* chore: update rediscloud-go-api and add AA test sweepers (#315)

* fix: AA regions bug and some assorted documentation things (#317)

* fix `make build` command

* fix: AA regions not setting resource ID when all regions already exist

* make `support_oss_cluster_api` optional to match docs

* docs: fix AA peering example to use AA subscription

* fix: importing active-active regions failing due to incorrect ID (#319)

* Update rediscloud_active_active_subscription.md

Fixes of documentation - rediscloud_active_active_subscription

* Update rediscloud_active_active_subscription_database.md

Align documentation - rediscloud_active_active_subscription_database resource

* fix: regions inactive subscription error and memory limit hardcoding (#320)

* fix: remove incorrect hardcoding of DB memory limit

* temp: change rediscloud-go-api dependency to branch

* fix: restructure regions resource to always use update logic, fix issue

Also some minor improvements such as code simplifications, and avoiding
the use of the `cmp` package which should only be used in tests as it
can panic instead of error for some conditions.

The create function now calls into the update function so that the logic
is consistent. It also rearranges a lot of the code so it is easier to
follow.

Finally the order of when things get created and deleted are more clear
and the appropriate waits are in place.

There is an outstanding TODO regarding subscription mutexes which I will
seek further clarification on before merging.

* chore: bump regions timeout to 1hr for extra subscription waits

* test: update tests to avoid CIDR clash error

* refactor: make AA subs cloud_provider default to AWS

* fix: move subscription mutex locking to guard actual update operations

* ci: change cloud account name

* chore: remove go.mod `replace` for go-api and upgrade (#329)

* refactor: remove support_oss_cluster_api from subscription creation plan (#330)

* refactor: remove support_oss_cluster_api from subscription creation plan

* test: remove `support_oss_cluster_api` attribute from test resources

* docs: remove `region_id` from active-active regions

* docs: set `region_id` and `vpc_id` as computed for regions resource

* refactor: rename to `database_id`

* refactor: change `vpc_cidrs` to `vpc_cidr` single string attribute

* docs: update peering `vpc_cidr` example

* Update rediscloud_active_active_subscription_database.md

* Update rediscloud_active_active_subscription_database.md

* Update rediscloud_active_active_regions.md (#336)

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

* Update rediscloud_active_active_regions.md

---------

Co-authored-by: Ben Gesoff <ben.gesoff@opencredo.com>

* Update docs/resources/rediscloud_active_active_subscription_database.md

Co-authored-by: Ben Gesoff <ben@gesoff.uk>

* Update rediscloud_active_active_subscription_peering.md (#337)

* Update rediscloud_subscription.md (#314)

Clarification for the users about this field.

* Update rediscloud_subscription.md (#311)

* Update rediscloud_subscription.md

As we are not supporting it for our hosted AWS solution, it may and confuse customers.

* Update rediscloud_subscription.md (#326)

Updates the AZ selection field description

* Update rediscloud_subscription.md (#322)

documentation adjustment

* Update rediscloud_subscription_database.md (#323)

Documentation adjustments

* Update rediscloud_subscription_database.md (#340)

* Update rediscloud_subscription_peering.md (#338)

* Update rediscloud_subscription.md (#339)

* Fixing ordering issue of delete and create + a new acceptance to test

* uncomment failing tests

* remove new line to re-run workflow

* add new line to re-run workflow

* Update rediscloud_active_active_subscription.md (#348)

* Update rediscloud_active_active_subscription_database.md (#345)

* Update rediscloud_active_active_regions.md (#343)

* Update rediscloud_active_active_regions.md (#350)

* Update rediscloud_active_active_subscription.md (#351)

* add the latest redis-go-api tag v0.2.0 to go.mod

---------

Co-authored-by: gregnuttall <greg.nuttall@opencredo.com>
Co-authored-by: Peter Vegh <peter.vegh@opencredo.com>
Co-authored-by: Greg Nuttall <102314841+greg-oc@users.noreply.github.com>
Co-authored-by: pvegh-oc <77333445+pvegh-oc@users.noreply.github.com>
Co-authored-by: danielarbiv <86226145+danielarbiv@users.noreply.github.com>
Co-authored-by: noham14 <45514308+noham14@users.noreply.github.com>
Co-authored-by: byron-oc <byron.oconnor@opencredo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greg-oc greg-oc greg-oc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noham14 @CLAassistant @greg-oc