fix: issues with global_default_user

.github/workflows/terraform_provider_pr.yml

@@ -56,6 +56,28 @@ jobs:
         name: go build
         run: go build -o terraform-plugin-dir/registry.terraform.io/RedisLabs/rediscloud/99.99.99/$(go env GOOS)_$(go env GOARCH)/terraform-provider-rediscloud .
 
+  go_unit_test:
+    name: go unit test
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        with:
+          go-version-file: go.mod
+      - run: go test ./... -run="^TestUnit"  # Runs tests starting with TestUnit
+
+  tfproviderlint:
+    name: tfproviderlint
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        with:
+          go-version-file: go.mod
+      - run: make tfproviderlint
+
   terraform_providers_schema:
     name: terraform providers schema
     needs: [go_build]
@@ -102,9 +124,33 @@ jobs:
           mkdir terraform-providers-schema
           terraform providers schema -json > terraform-providers-schema/schema.json
 
+  # All acceptance tests run in parallel after quick tests
+  go_test_smoke_aa_tgw_attachment:
+    if: false  # Temporarily disabled - TGW tests not ready yet
+    name: go test smoke aa tgw attachment
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        with:
+          go-version-file: go.mod
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveTransitGatewayAttachment_CRUDI"'
+
+  go_test_smoke_aa_enable_default_user:
+    name: go test smoke aa enable default user
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        with:
+          go-version-file: go.mod
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveDatabase_enableDefaultUser"'
+
   go_test_smoke_aa_db:
     name: go test smoke aa db
-    needs: [go_build]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -115,7 +161,7 @@ jobs:
 
   go_test_smoke_essentials_sub:
     name: go test smoke essentials sub
-    needs: [go_build]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -139,7 +185,7 @@ jobs:
 
   go_test_smoke_pro_db:
     name: go test smoke pro db
-    needs: [go_build]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -151,7 +197,7 @@ jobs:
 
   go_test_smoke_misc:
     name: go test smoke misc
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -162,7 +208,7 @@ jobs:
 
   go_test_pro_db_upgrade:
     name: go test smoke pro db upgrade
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -173,7 +219,7 @@ jobs:
 
   go_test_privatelink:
     name: go test smoke privatelink
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -185,7 +231,7 @@ jobs:
 
   go_test_block_public_endpoints:
     name: go test smoke public endpoints
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -196,33 +242,11 @@ jobs:
 
   go_test_smoke_qpf:
     name: go test smoke query performance factor
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version-file: go.mod
       - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudProDatabase_qpf"'
-
-  go_unit_test:
-    name: go unit test
-    needs: [go_build]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-        with:
-          go-version-file: go.mod
-      - run: go test ./... -run="^TestUnit"  # Runs tests starting with TestUnit
-
-  tfproviderlint:
-    name: tfproviderlint
-    needs: [go_build]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-        with:
-          go-version-file: go.mod
-      - run: make tfproviderlint

CHANGELOG.md

@@ -4,6 +4,20 @@ All notable changes to this project will be documented in this file.
 See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
 
 
+# 2.7.3 (6th November 2025)
+
+## Changed
+- Reworked the entire interaction between global/regional overrides and how they read config and state. This should fix many existing subtle state drift bugs.
+
+## Fixed
+- `rediscloud_active_active_subscription_database`: Fixed multiple issues concerning regional `enable_default_user` and `global_enable_default_user` to do with drift or incorrectly not detecting changes.
+- The default for `global_enable_default_user` was omitted, it is now set to true.
+- `rediscloud_active_active_transit_gateway_attachment`: Fixed parameter order bug in update operation.
+
+## Testing
+- Added acceptance tests covering `enable_default_user` inheritance and override scenarios
+- Added acceptance test for `rediscloud_active_active_transit_gateway_attachment` resource lifecycle (Create/Read/Update/Delete/Import)
+
 # 2.7.2 (3rd November 2025)
 
 ## Fixed

provider/activeactive/testdata/enable_default_user_all_explicit.tf

@@ -0,0 +1,54 @@
+# Template signature: fmt.Sprintf(template, subscription_name, database_name, password)
+locals {
+	subscription_name = "%s"
+	database_name     = "%s"
+	password          = "%s"
+}
+
+data "rediscloud_payment_method" "card" {
+	card_type = "Visa"
+	last_four_numbers = "5556"
+}
+
+resource "rediscloud_active_active_subscription" "test" {
+	name = local.subscription_name
+	payment_method_id = data.rediscloud_payment_method.card.id
+	cloud_provider = "AWS"
+
+	creation_plan {
+		dataset_size_in_gb = 1
+		quantity = 1
+		region {
+			region = "us-east-1"
+			networking_deployment_cidr = "192.168.0.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+		region {
+			region = "us-east-2"
+			networking_deployment_cidr = "10.0.1.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+	}
+}
+
+resource "rediscloud_active_active_subscription_database" "test" {
+	subscription_id = rediscloud_active_active_subscription.test.id
+	name = local.database_name
+	dataset_size_in_gb = 1
+	global_password = local.password
+	global_enable_default_user = true
+
+	# us-east-1: explicitly true
+	override_region {
+		name = "us-east-1"
+		enable_default_user = true
+	}
+
+	# us-east-2: explicitly false
+	override_region {
+		name = "us-east-2"
+		enable_default_user = false
+	}
+}

provider/activeactive/testdata/enable_default_user_global_false_region_true.tf

@@ -0,0 +1,53 @@
+# Template signature: fmt.Sprintf(template, subscription_name, database_name, password)
+locals {
+	subscription_name = "%s"
+	database_name     = "%s"
+	password          = "%s"
+}
+
+data "rediscloud_payment_method" "card" {
+	card_type = "Visa"
+	last_four_numbers = "5556"
+}
+
+resource "rediscloud_active_active_subscription" "test" {
+	name = local.subscription_name
+	payment_method_id = data.rediscloud_payment_method.card.id
+	cloud_provider = "AWS"
+
+	creation_plan {
+		dataset_size_in_gb = 1
+		quantity = 1
+		region {
+			region = "us-east-1"
+			networking_deployment_cidr = "192.168.0.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+		region {
+			region = "us-east-2"
+			networking_deployment_cidr = "10.0.1.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+	}
+}
+
+resource "rediscloud_active_active_subscription_database" "test" {
+	subscription_id = rediscloud_active_active_subscription.test.id
+	name = local.database_name
+	dataset_size_in_gb = 1
+	global_password = local.password
+	global_enable_default_user = false
+
+	# us-east-1: explicitly enable (override global false)
+	override_region {
+		name = "us-east-1"
+		enable_default_user = true
+	}
+
+	# us-east-2: inherit global=false
+	override_region {
+		name = "us-east-2"
+	}
+}

provider/activeactive/testdata/enable_default_user_global_true_inherit.tf

@@ -0,0 +1,52 @@
+# Template signature: fmt.Sprintf(template, subscription_name, database_name, password)
+locals {
+	subscription_name = "%s"
+	database_name     = "%s"
+	password          = "%s"
+}
+
+data "rediscloud_payment_method" "card" {
+	card_type = "Visa"
+	last_four_numbers = "5556"
+}
+
+resource "rediscloud_active_active_subscription" "test" {
+	name = local.subscription_name
+	payment_method_id = data.rediscloud_payment_method.card.id
+	cloud_provider = "AWS"
+
+	creation_plan {
+		dataset_size_in_gb = 1
+		quantity = 1
+		region {
+			region = "us-east-1"
+			networking_deployment_cidr = "192.168.0.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+		region {
+			region = "us-east-2"
+			networking_deployment_cidr = "10.0.1.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+	}
+}
+
+resource "rediscloud_active_active_subscription_database" "test" {
+	subscription_id = rediscloud_active_active_subscription.test.id
+	name = local.database_name
+	dataset_size_in_gb = 1
+	global_password = local.password
+	global_enable_default_user = true
+
+	# Both regions should inherit global=true
+	# Before fix: would send enableDefaultUser=false to API
+	# After fix: should NOT send enableDefaultUser at all
+	override_region {
+		name = "us-east-1"
+	}
+	override_region {
+		name = "us-east-2"
+	}
+}

provider/activeactive/testdata/enable_default_user_mixed_overrides.tf

@@ -0,0 +1,53 @@
+# Template signature: fmt.Sprintf(template, subscription_name, database_name, password)
+locals {
+	subscription_name = "%s"
+	database_name     = "%s"
+	password          = "%s"
+}
+
+data "rediscloud_payment_method" "card" {
+	card_type = "Visa"
+	last_four_numbers = "5556"
+}
+
+resource "rediscloud_active_active_subscription" "test" {
+	name = local.subscription_name
+	payment_method_id = data.rediscloud_payment_method.card.id
+	cloud_provider = "AWS"
+
+	creation_plan {
+		dataset_size_in_gb = 1
+		quantity = 1
+		region {
+			region = "us-east-1"
+			networking_deployment_cidr = "192.168.0.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+		region {
+			region = "us-east-2"
+			networking_deployment_cidr = "10.0.1.0/24"
+			write_operations_per_second = 1000
+			read_operations_per_second = 1000
+		}
+	}
+}
+
+resource "rediscloud_active_active_subscription_database" "test" {
+	subscription_id = rediscloud_active_active_subscription.test.id
+	name = local.database_name
+	dataset_size_in_gb = 1
+	global_password = local.password
+	global_enable_default_user = true
+
+	# us-east-1: explicitly disable (override global)
+	override_region {
+		name = "us-east-1"
+		enable_default_user = false
+	}
+
+	# us-east-2: inherit global=true
+	override_region {
+		name = "us-east-2"
+	}
+}