Skip to content

Conversation

@derpda
Copy link
Contributor

@derpda derpda commented Dec 20, 2020

Allow users to choose whether they want to build tests or not.

See #29 for some initial discussion.
By default, tests are build as was the case before this PR.
By using cmake -DSCALAPACK_BUILD_TESTS=OFF, users can turn off building tests and save on build time.
The same was possible by specifying a target (make scalapack), but giving a cmake option is good practice I believe.

Note that PBLAS/TIMING is also considered a "test" and is thus not build when SCALAPACK_BUILD_TESTS is turned off by the user.

Miscellaneous

I also deleted some spaces at the end of several lines (automatically, many editors like vim do this).

PBLAS/TIMING also considered TEST
Spaces at end of line, automatically deleted by vim/vscode etc.
@langou langou merged commit 6819b24 into Reference-ScaLAPACK:master Dec 26, 2020
@langou
Copy link
Contributor

langou commented Dec 26, 2020

Thanks @derpda

@julielangou julielangou added this to the 2.2 release milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants