First attempt fixing null properties of Values<> #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Yes, I tried the same and got the same weird result. Needs more investigation. |
RehanSaeed
reviewed
May 27, 2019
| /// <summary> | ||
| /// Gets whether the value of either type <typeparamref name="T1" />, type <typeparamref name="T2" />, type <typeparamref name="T3" />, or type <typeparamref name="T4" /> has a value. | ||
| /// </summary> | ||
| public bool HasValue => this.HasValue1 || this.HasValue2 || this.HasValue3 || this.HasValue4; |
Owner
There was a problem hiding this comment.
Nice idea. This should be another PR. Looks like we might not get this one in quickly.
Contributor
Author
There was a problem hiding this comment.
Ye this was mainly so the tests would continue passing, as quite a few relied on Nullable<>.HasValue, and broke when we removed the ?
Contributor
Author
|
Just to note that I'm on leave for the next few days, but any ideas from anyone on this very welcome! |
Owner
|
Added your |
Merged
Owner
|
Closing in favour of #84. Thanks for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RehanSaeed I've had a go at refactoring along the lines you explained, but all nulls now seem to be rendering... for both
OneOrMany<>andValues<>!Did I miss something here?