Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Aug 31, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@Rel1cx Rel1cx requested a review from Copilot August 31, 2025 18:30
@vercel
Copy link

vercel bot commented Aug 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Building Building Preview Comment Aug 31, 2025 6:30pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This refactor improves the type definitions for ESLint compatibility by introducing a more specific CompatibleRule interface and updating related types. The changes enhance type safety while maintaining compatibility with both defineConfig() and tseslint.config().

  • Introduces CompatibleRule interface with explicit meta and create properties
  • Updates CompatiblePlugin.rules to use the new CompatibleRule type instead of generic any
  • Removes redundant | undefined from CompatibleConfig.settings type
  • Cleans up unused RuleConfig imports across plugin files

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/utilities/kit/src/types.ts Adds CompatibleRule interface and refines existing compatibility types
packages/plugins/eslint-plugin-react-x/src/index.ts Removes unused RuleConfig import
packages/plugins/eslint-plugin-react-web-api/src/index.ts Removes unused RuleConfig import
packages/plugins/eslint-plugin-react-naming-convention/src/index.ts Removes unused RuleConfig import
packages/plugins/eslint-plugin-react-hooks-extra/src/index.ts Removes unused RuleConfig import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx merged commit a0bbbd8 into 2.0.0 Aug 31, 2025
8 of 9 checks passed
@Rel1cx Rel1cx deleted the compatible-types branch August 31, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants