Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Sep 1, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Building Building Preview Comment Sep 1, 2025 2:13am

@Rel1cx Rel1cx merged commit 2fdba1d into main Sep 1, 2025
8 of 9 checks passed
@Rel1cx Rel1cx requested a review from Copilot September 1, 2025 02:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors type definitions throughout the codebase to improve type safety and reduce code duplication. The main changes consolidate compatibility types into a single location and replace the deprecated RulePreset type with more explicit type definitions.

  • Consolidates compatibility types from @eslint-react/shared into @eslint-react/kit
  • Replaces RulePreset type usage with Record<string, RuleConfig> for better type clarity
  • Introduces a reusable getConfigAdapters utility to eliminate duplicate config adapter implementations

Reviewed Changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/utilities/kit/src/types.ts Adds comprehensive type definitions including severity types, rule configurations, and compatibility interfaces
packages/shared/src/compatibility-types.ts Removes duplicate compatibility type definitions (moved to kit package)
packages/shared/src/get-config-adapters.ts Adds new utility function for generating config adapters
Multiple config files Updates type annotations from RulePreset to Record<string, RuleConfig>
Multiple plugin files Replaces inline config adapter functions with shared getConfigAdapters utility
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants