feat: new jsx element and attribute resolution for dom rules #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Rel1cx
changed the title
…arget-blank.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <rel1cx@proton.me>
…element-resolver.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <rel1cx@proton.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new JSX element and attribute resolution system for DOM rules, removing the legacy custom component configuration feature while improving the core attribute resolution functionality.
- Refactors the JSX attribute resolution system to use a curried function approach for better API design
- Removes support for custom component configuration (
additionalComponents) from settings - Introduces new
resolveAttributeValuefunction with improved type safety and static value extraction
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/utilities/ast/src/node-types.ts | Adds new type definition for JSX attribute-like nodes |
| packages/shared/src/settings.ts | Removes custom component schema and related functionality |
| packages/core/src/jsx/jsx-attribute.ts | Refactors getAttribute to return a curried function |
| packages/core/src/jsx/jsx-attribute-value.ts | Replaces getAttributeValue with new resolveAttributeValue function |
| packages/plugins/eslint-plugin-react-dom/src/utils/ | Removes custom component utilities and updates element resolver |
| packages/plugins/eslint-plugin-react-dom/src/rules/ | Updates all DOM rules to use new attribute resolution API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/plugins/eslint-plugin-react-dom/src/rules/no-unsafe-target-blank.spec.ts
Show resolved
Hide resolved
packages/plugins/eslint-plugin-react-dom/src/utils/create-jsx-element-resolver.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information