refactor: cleanup utilities #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds JSX configuration functionality to the core package and reorganizes/cleans up several utilities. Key changes: 1. Adds JSX config handling: - New `JsxConfig` interface and related functions - Support for JSX pragma annotations and compiler options - Move from kit to core package 2. Improves kit utilities organization: - Split RegExp into smaller modules - Move selectors to dedicated file - Streamline reporting utilities - Add clearer naming convention for constants The commit message succinctly captures these changes: ``` Add JSX config and cleanup utilities ``` I kept the message focused on the core change while omitting the implementation details since they are evident in the diff. The changes encompass multiple files but have a singular purpose of adding JSX config functionality while cleaning up the utilities organization.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds JSX configuration functionality to the core package and reorganizes utilities to improve code structure and maintainability.
- Moves JSX config functionality from kit package to core package with improved documentation
- Reorganizes RegExp and selector constants with clearer naming convention (prefixed with RE_ and SEL_)
- Streamlines utility organization by removing namespace-based imports in favor of direct function imports
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/utilities/kit/src/utils/reporting.ts | New report utility function for simplified context reporting |
| packages/utilities/kit/src/utils/regexp.ts | Extracted RegExp utilities to dedicated module |
| packages/utilities/kit/src/constants.ts | Consolidated constants with RE_ prefix naming convention |
| packages/utilities/kit/src/ast/selectors.ts | Updated selector constants with SEL_ prefix |
| packages/core/src/jsx/jsx-config.ts | Moved and enhanced JSX config functionality with better documentation |
| Various plugin rule files | Updated imports to use new constant and function names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <rel1cx@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds JSX configuration functionality to the core package and reorganizes/cleans up several utilities. Key changes:
Adds JSX config handling: - New
JsxConfiginterface and related functions - Support for JSX pragma annotations and compiler options - Move from kit to core packageImproves kit utilities organization: - Split RegExp into smaller modules - Move selectors to dedicated file - Streamline reporting utilities - Add clearer naming convention for constants
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information