Replace getId with IdGenerator across collectors
#1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the internal ID generation mechanism from a simple function to a class-based IdGenerator with configurable prefixes. The implementation changes from decimal string IDs to hexadecimal representation and uses bitwise OR operation on bigint values.
- Replaced simple
getId()function withIdGeneratorclass supporting custom prefixes - Updated all usages across component and hook collectors to use the new
IdGeneratorinstances - Fixed a bug in
component-collector.tswhere duplicate ID generation was causing key collisions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/_id.ts | Replaces simple getId() function with IdGenerator class featuring configurable prefixes and hexadecimal output |
| packages/shared/docs/classes/IdGenerator.md | Adds API documentation for the new IdGenerator class |
| packages/shared/docs/README.md | Updates index to include IdGenerator class reference |
| packages/core/src/hook/hook-collector.ts | Migrates from getId() to IdGenerator instance with "hook_" prefix |
| packages/core/src/component/component-collector.ts | Migrates to IdGenerator with "function_component_" prefix and fixes duplicate key generation bug |
| packages/core/src/component/component-collector-legacy.ts | Migrates to IdGenerator instance with "class_component_" prefix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <rel1cx@proton.me>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <rel1cx@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information