Skip to content

Conversation

@ha1fstack
Copy link
Contributor

@ha1fstack ha1fstack commented Nov 26, 2025

What kind of change does this PR introduce?

@typescript-eslint/utils requires eslint and typescript as peer dependency

@typescript-eslint/typescript-estree requires typescript as peer dependency

Some of the eslint-react packages didn't specify peerDeps so handled those correctly.

Also, the existing peerDeps configs are needlessly set too narrow so I matched it with actual ts-eslint peerDeps requirements.

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel
Copy link

vercel bot commented Nov 26, 2025

@ha1fstack is attempting to deploy a commit to the Rel1cx's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ha1fstack ha1fstack changed the title chore: correct peer dependencies chore: specify peer dependencies Nov 26, 2025
@ha1fstack ha1fstack marked this pull request as ready for review November 26, 2025 09:37
@ha1fstack ha1fstack marked this pull request as draft November 26, 2025 09:40
@ha1fstack ha1fstack marked this pull request as ready for review November 26, 2025 09:44
@ha1fstack ha1fstack changed the title chore: specify peer dependencies chore: correct peer dependencies Nov 26, 2025
@ha1fstack ha1fstack force-pushed the chore/peer-dependency branch from 54ebf2c to f8a65e2 Compare November 26, 2025 09:46
@Rel1cx Rel1cx self-requested a review November 26, 2025 10:14
@vercel
Copy link

vercel bot commented Nov 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Nov 26, 2025 10:17am

Copy link
Owner

@Rel1cx Rel1cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Rel1cx Rel1cx merged commit fb46fe7 into Rel1cx:main Nov 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants