Chore/rector code quality improvements #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request downgrades Laravel framework support from version 12 to version 11, along with making various code quality improvements. The changes include adding explicit return types to closures, refactoring empty value checks to use in_array() for better type safety, removing default parameters from rescue() helper calls, and updating PHPDoc type hints.
- Downgraded Laravel framework from v12 to v11 with corresponding package updates
- Added explicit return types to numerous closure functions throughout the codebase
- Refactored empty value checks from chained comparisons to
in_array()for strict type checking - Removed default null parameters from
rescue()helper function calls
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated orchestra/testbench requirement from ^10.0 to ^9.0 |
| composer.lock | Downgraded Laravel framework from v12.36.1 to v11.46.1 with dependency updates |
| .github/workflows/run-tests.yml | Updated CI matrix to use Laravel 11., testbench 9., and carbon 2.* |
| tests/TestCase.php | Removed second argument from config()->set() call |
| tests/Feature/Integration/Resources/Pages/CreateRecordTest.php | Removed test case for 'date field must be valid date' |
| src/Services/Visibility/FrontendVisibilityService.php | Replaced chained comparisons with in_array() for empty checks |
| src/Providers/EntityServiceProvider.php | Added return type array to closure |
| src/Models/CustomFieldSection.php | Removed 'bool' from PHPDoc type annotation |
| src/Models/CustomFieldOption.php | Replaced chained comparisons with in_array() |
| src/Models/CustomField.php | Removed 'bool' from PHPDoc type annotation |
| src/Filament/Management/Pages/CustomFieldsManagementPage.php | Replaced chained comparisons with in_array() in two methods |
| src/Filament/Management/Forms/Components/VisibilityComponent.php | Removed default null parameters from rescue() calls |
| src/Filament/Management/Forms/Components/CustomFieldValidationComponent.php | Added return type to closure and replaced chained comparisons |
| src/Filament/Integration/Migrations/CustomFieldsMigrator.php | Added return type array to closure |
| src/Filament/Integration/Builders/InfolistBuilder.php | Added return type bool to nested closure |
| src/Filament/Integration/Base/AbstractFormComponent.php | Refactored visibility check logic and simplified ternary |
| src/Enums/VisibilityOperator.php | Added return type array to closure |
| src/Enums/ValidationRule.php | Replaced chained comparisons with in_array() |
| src/Enums/FieldDataType.php | Added return type array to closure |
| src/EntitySystem/EntityCollection.php | Added return type array to closures in two methods |
| src/Data/CustomFieldSectionSettingsData.php | Simplified empty class definition |
| src/CustomFields.php | Changed static:: to self:: for property access |
| rector.php | Removed strictBooleans configuration option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Fix Spatie Laravel Data configuration for testing | ||
| config()->set('data.throw_when_max_depth_reached', false); | ||
| config()->set('data.max_transformation_depth', null); | ||
| config()->set('data.max_transformation_depth'); |
There was a problem hiding this comment.
The config()->set() call is missing its second argument. The value parameter is required to set a configuration value. This line should either provide a value (e.g., null) or be removed if the configuration should not be set.
Suggested change
| config()->set('data.max_transformation_depth'); | |
| config()->set('data.max_transformation_depth', null); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.