Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,15 @@ jobs:
build_rust: true
julia_version: '1.11'
os: ubuntu-latest
arch: x64
arch: x64

rust-format-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt
- name: Check Rust formatting
run: cargo fmt --all -- --check
working-directory: iceberg_rust_ffi
5 changes: 4 additions & 1 deletion iceberg_rust_ffi/src/incremental.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ impl_scan_builder_method!(
with_concurrency_limit_manifest_entries
);

impl_with_batch_size!(iceberg_incremental_scan_with_batch_size, IcebergIncrementalScan);
impl_with_batch_size!(
iceberg_incremental_scan_with_batch_size,
IcebergIncrementalScan
);

impl_scan_build!(iceberg_incremental_scan_build, IcebergIncrementalScan);

Expand Down
4 changes: 1 addition & 3 deletions iceberg_rust_ffi/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ use object_store_ffi::{
};

// Modules for scan functionality
mod scan_common;
mod full;
mod incremental;
mod scan_common;

// Re-export scan types and functions
pub use full::IcebergScan;
Expand Down Expand Up @@ -97,7 +97,6 @@ pub struct IcebergTable {
pub table: Table,
}


// Stream wrapper for FFI - using async mutex to avoid blocking calls
#[repr(C)]
pub struct IcebergArrowStream {
Expand Down Expand Up @@ -363,7 +362,6 @@ export_runtime_op!(
properties_len: usize
);


// Async function to get next batch from existing stream
export_runtime_op!(
iceberg_next_batch,
Expand Down
2 changes: 1 addition & 1 deletion iceberg_rust_ffi/src/scan_common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ macro_rules! impl_scan_free {
}

// Re-export macros for use in other modules
pub(crate) use impl_scan_builder_method;
pub(crate) use impl_scan_build;
pub(crate) use impl_scan_builder_method;
pub(crate) use impl_scan_free;
pub(crate) use impl_select_columns;
pub(crate) use impl_with_batch_size;