Add support for file column #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrgr
commented
Nov 19, 2025
| export with_file_column! | ||
| export scan!, next_batch, free_batch, free_stream | ||
|
|
||
| const Option{T} = Union{T, Nothing} |
Contributor
Author
There was a problem hiding this comment.
Removing this one here in this PR, as it is not used.
vustef
reviewed
Nov 19, 2025
vustef
approved these changes
Nov 20, 2025
| stream = scan!(scan) | ||
| ``` | ||
| """ | ||
| const FILE_COLUMN = "_file" |
Collaborator
There was a problem hiding this comment.
I thought you said you wanted to make this a function and fetch from rust_lib that way?
Contributor
Author
There was a problem hiding this comment.
That's what I mentioned in the meeting: that does not work cleanly
vustef
reviewed
Nov 20, 2025
| )::Cint | ||
|
|
||
| if result != 0 | ||
| error("Failed to add file column to scan") |
Collaborator
There was a problem hiding this comment.
Perhaps we can throw IcebergException instead of this one? Not sure, we're not consistent in this regard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
_filecolumn used in projections of scans.