RAI-11434 refactor polling transaction logic #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisgursky
reviewed
May 5, 2023
src/rest.ts
Outdated
| timeout?: number; | ||
| }; | ||
|
|
||
| export type PollingResult<T> = |
Contributor
There was a problem hiding this comment.
Hm, why not just
export type PollingResult<T> = {
done: boolean;
result?: T;
};
src/rest.ts
Outdated
|
|
||
| export type PollOptions = { | ||
| overheadRate?: number; | ||
| startTime?: number; |
Contributor
There was a problem hiding this comment.
startTime looks kinda weird, doesn't it?
Contributor
Author
There was a problem hiding this comment.
So do we want to hardcode it in the pollWithOverhead function to Date.now, or we should just not expose it in the exec and pollTransaction options?
Contributor
There was a problem hiding this comment.
Hardcode in pollWithOverhead
src/api/query/execAsyncApi.ts
Outdated
| readonly = true, | ||
| tags: string[] = [], | ||
| interval = 1000, // 1 second | ||
| timeout = Number.POSITIVE_INFINITY, |
Contributor
There was a problem hiding this comment.
Should be options?: PollOptions, to be consistent with the poll function
denisgursky
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.