Skip to content

Conversation

@denisgursky
Copy link
Contributor

@denisgursky denisgursky commented May 4, 2023

Fixes RAI-10238

Before:
https://github.com/RelationalAI/rai-sdk-javascript/actions/runs/4884031855/jobs/8716188974

PASS src/api/query/execAsyncApi.test.ts
  QueryAsyncApi
    ✓ should exec query async (5 ms)


Jest global teardown
Deleting js-sdk-tests-1683210703420 engine
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @relationalai/rai-sdk-javascript@0.7.0 test: `jest --verbose --runInBand`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @relationalai/rai-sdk-javascript@0.7.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-05-04T14_42_22_247Z-debug.log
Error: Process completed with exit code 1.

After:
https://github.com/RelationalAI/rai-sdk-javascript/actions/runs/4884086341/jobs/8716313964

PASS src/api/edb/edbApi.test.ts
  EdbApi
    ✓ should list edbs (7 ms)
    ✓ should delete edb (4 ms)

PASS src/api/query/execAsyncApi.test.ts
  QueryAsyncApi
    ✓ should exec query async (9 ms)

Test Suites: 2 failed, 11 passed, 13 total
Tests:       2 failed, 2 skipped, 234 passed, 238 total
Snapshots:   0 total
Time:        671.761 s
Ran all test suites.

Jest global teardown
Deleting js-sdk-tests-1683211021616 engine
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @relationalai/rai-sdk-javascript@0.7.0 test: `jest --verbose --runInBand`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @relationalai/rai-sdk-javascript@0.7.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-05-04T14_49_08_541Z-debug.log
Error: Process completed with exit code 1.

The ELIFECYCLE is still there, but there's also this:

Test Suites: 2 failed, 11 passed, 13 total
Tests:       2 failed, 2 skipped, 234 passed, 238 total
Snapshots:   0 total
Time:        671.761 s

It should be easy to spot. ELIFECYCLE is produced by NPM, we can suppress NPM error messages https://stackoverflow.com/questions/34426332/how-to-suppress-output-when-running-npm-scripts, but I'd rather not do that because it'd suppress other errors as well.

@denisgursky denisgursky requested review from OsamaSBCrea and larf311 May 4, 2023 15:03
@denisgursky denisgursky merged commit 15496ee into main May 4, 2023
@denisgursky denisgursky deleted the dg-test-summary branch May 4, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants