Skip to content

Conversation

@MwanPygmay
Copy link
Contributor

@MwanPygmay MwanPygmay commented Apr 17, 2024

Description

Now able to get points instead of polygons for layers using admin fields.
Added some types.

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

On DEV database, in SUI, checked the polygons layers still worked. Checked in the Signals page of SUI - Matthieu that points were displayed instead of polygons.

Screenshots

image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

…se enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@MwanPygmay MwanPygmay requested a review from a team April 17, 2024 10:12
@MwanPygmay MwanPygmay self-assigned this Apr 17, 2024
@AntoineRelief AntoineRelief merged commit 6cf9a4b into 2.x.x Apr 17, 2024
@AntoineRelief AntoineRelief deleted the AB#90343_points_layers_with_iso2code branch April 17, 2024 13:43
AntoineRelief pushed a commit that referenced this pull request Apr 24, 2024
…04-24) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json context could be wrong in SUI, due to providers ([6708196](6708196)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json context filter not taken into account while using resource & summary cards ([#2465](#2465)) ([05f8b18](05f8b18)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json increase gridster default max col to be infinity: no more constraints ([#2469](#2469)) ([11d0cf1](11d0cf1)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json layers can now use admin0 center latitude & longitude ([#2471](#2471)) ([6cf9a4b](6cf9a4b)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json reallow default position and remove buttons when no value ([#2474](#2474)) ([50a571e](50a571e)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json rerender question with choicesByGraphQL when trigger activated ([#2473](#2473)) ([9db71e5](9db71e5)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Add email + AAD user type to automation rules ([#2468](#2468)) ([e898c3b](e898c3b)), closes [#89936](https://github.com/ReliefApplications/ems-frontend/issues/89936) [#89936](https://github.com/ReliefApplications/ems-frontend/issues/89936) [#89936](https://github.com/ReliefApplications/ems-frontend/issues/89936) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add tooltips for html question ([#2480](#2480)) ([87a2b21](87a2b21)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json allow ignoring webmap default state ([#2472](#2472)) ([6a04854](6a04854)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json role based display for action buttons ([#2461](#2461)) ([84abc92](84abc92)) ### Reverts CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "refactor: application scss endpoint now using text/plain (#2467)" (#2470) ([a541694](a541694)), closes [#2467](#2467) [#2470](#2470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants