Logging should be opt-in

[xMartin]

I'd like the console logs to be opt-in instead of opt-out.

[silverbucket]

+1 (and it should be very obvious how to do this), maybe an optional param
during the first init command.

On Mon, Jan 28, 2013 at 12:59 PM, xMartin notifications@github.com wrote:

I'd like the console logs to be opt-in instead of opt-out.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/221.

[raucao]

+1

I think I recently saw a proper logger being used now. So I guess default level should be warn instead of info.

[nilclass]

@skddc there is no level "warn", just "error", "info" and "debug". In the 0.7 release the default logging settings are:

• log level "info"
• all loggers disabled, except "base" and "getputdelete"

So you should only see log messages of the requests being made (from getputdelete) and when local data is being flushed (from base).

For convenience we could add a widget option that enables the logger and have it silenced completely by default.

Something like:

remoteStorage.displayWidget('...', { log: true });

?

[silverbucket]

+1 -- i like the idea of an object of named properties defining the config
of RS during initialization. This was it's easy for people to check the
docs to see all the options they have, no searching for different function
names, just reading params - one call, done.

On Mon, Jan 28, 2013 at 2:33 PM, Niklas Cathor notifications@github.comwrote:

@skddc https://github.com/skddc there is no level "warn", just "error",
"info" and "debug". In the 0.7 release the default logging settings are:

• log level "info"
• all loggers disabled, except "base" and "getputdelete"

So you should only see log messages of the requests being made (from
getputdelete) and when local data is being flushed (from base).

For convenience we could add a widget option that enables the logger and
have it silenced completely by default.

Something like:

remoteStorage.displayWidget('...', { log: true });

?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/221#issuecomment-12781685.

[raucao]

Shouldn't be defined on a function that displays UI elements though. I see the ideal case more like:

remoteStorage.init('...', { log: true, displayWidget: false });

;)

[silverbucket]

Ah yes, that's what I intended as well :)

On Mon, Jan 28, 2013 at 2:42 PM, Sebastian Kippe
notifications@github.comwrote:

Shouldn't be defined on a function that displays UI elements though. I see
the ideal case more like:

remoteStorage.init('...', { log: true, displayWidget: false });

;)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/221#issuecomment-12782044.

[michielbdejong]

@nilclass logging is now opt-in, right? can this be closed?