Skip to content

Added formatting to checksum addresses #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Added formatting to checksum addresses #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/create-invoice-form/src/lib/utils/prepareRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { parseUnits, zeroAddress, getAddress } from "viem";
import { Types, Utils } from "@requestnetwork/request-client.js";
import type { CustomFormData } from "@requestnetwork/shared-types";
import { parseUnits, zeroAddress } from "viem";

interface IRequestParams {
currency: any;
Expand Down Expand Up @@ -34,11 +34,11 @@ export const prepareRequestParams = ({
).toString(),
payee: {
type: Types.Identity.TYPE.ETHEREUM_ADDRESS,
value: formData.creatorId,
value: getAddress(formData.creatorId),
},
payer: {
type: Types.Identity.TYPE.ETHEREUM_ADDRESS,
value: formData.payerAddress,
value: getAddress(formData.payerAddress),
},
timestamp: Utils.getCurrentTimestampInSecond(),
},
Expand All @@ -49,7 +49,7 @@ export const prepareRequestParams = ({
: Types.Extension.PAYMENT_NETWORK_ID.ERC20_FEE_PROXY_CONTRACT,
parameters: {
paymentNetworkName: currency.network,
paymentAddress: formData.payeeAddress,
paymentAddress: getAddress(formData.payeeAddress),
feeAddress: zeroAddress,
feeAmount: "0",
},
Expand Down Expand Up @@ -122,7 +122,7 @@ export const prepareRequestParams = ({
},
signer: {
type: Types.Identity.TYPE.ETHEREUM_ADDRESS,
value: address as string,
value: getAddress(address as string),
},
};
};
5 changes: 4 additions & 1 deletion packages/invoice-dashboard/src/utils/formatAddress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { getAddress } from "viem";
import { checkAddress } from "@requestnetwork/shared-utils/checkEthAddress";

export const formatAddress = (
Expand All @@ -9,5 +10,7 @@ export const formatAddress = (
console.error("Invalid address!");
}

return `${address.slice(0, first)}...${address.slice(-last)}`;
const checksumAddress = getAddress(address);

return `${checksumAddress.slice(0, first)}...${checksumAddress.slice(-last)}`;
};