update_jsonld: do not modify the caller's dict

Author: simleo

rocrate/rocrate.py

@@ -558,11 +558,7 @@ def update_jsonld(self, jsonld):
         entity: Entity = self.get(entity_id)
         if not entity:
             raise ValueError(f"entity {entity_id} does not exist in the RO-Crate")
-        # Keys starting with @ are removed here to avoid messing up things.
-        # https://github.com/ResearchObject/ro-crate-py/pull/149#issuecomment-1487039274
-        for key in list(jsonld.keys()):
-            if key.startswith('@'):
-                del jsonld[key]
+        jsonld = {k: v for k, v in jsonld.items() if not k.startswith('@')}
         entity._jsonld.update(jsonld)
         return entity
 

test/test_jsonld.py

@@ -157,6 +157,8 @@ def test_update_jsonld(test_data_dir):
     assert updated_entity.type == 'CreativeWork'
     assert updated_entity['name'] == 'No potatoes today'
 
+    assert '@type' in update_dict
+
 
 # --- add or update