Localize the storage units (MiB, GiB, etc.), in particular for the StorageUsageStatus component #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why remove other names from locale authors? |
Contributor
Author
|
Gah, dammit - I copied the en.json and then accidentally edited that when I wanted to make the other one. Missed undoing that. |
Nytra
approved these changes
May 20, 2025
…orageUsageStatus component Adds a fix for Yellow-Dog-Man/Resonite-Issues#1269 / Yellow-Dog-Man/Locale#186
Banane9
force-pushed
the
feature/localizable-storage-units
branch
from
e1b5952 to
6b93089
Compare
l-2-j
reviewed
May 21, 2025
Comment on lines
+5
to
+10
| "CommunityBugFixCollection.StorageUnits.B": "t", | ||
| "CommunityBugFixCollection.StorageUnits.kB": "Kit", | ||
| "CommunityBugFixCollection.StorageUnits.MB": "Mit", | ||
| "CommunityBugFixCollection.StorageUnits.GB": "Git", | ||
| "CommunityBugFixCollection.StorageUnits.TB": "Tit", | ||
| "CommunityBugFixCollection.StorageUnits.PB": "Pit" |
Contributor
There was a problem hiding this comment.
wtf are these? Never heard anyone use anything like these …I guess the saving grace is that this monkey can be disabled…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix for Yellow-Dog-Man/Resonite-Issues#1269 / Yellow-Dog-Man/Locale#186