Skip to content

Conversation

@l-2-j
Copy link
Contributor

@l-2-j l-2-j commented May 21, 2025

At least t (tavua) is better than whatever it was supposed to stand for

At `t` (tavua) is least better than whatever `it` was supposed to stand for
@l-2-j l-2-j requested a review from Banane9 May 21, 2025 19:59
@l-2-j l-2-j self-assigned this May 21, 2025
@l-2-j
Copy link
Contributor Author

l-2-j commented May 21, 2025

Honesty should just use the original B instead of t, since like commented on the original PR, it's usually just shortened to the OG ones, https://www.kielitoimistonsanakirja.fi/#/kilotavu for example lists kilobyte shorthands as kB. But then kilos are a special case and rest is actually uppercase, like MB? … who came up with this…

Looking into this more with the worlds most trustworthy cough source https://fi.wikipedia.org/wiki/Tavu_(tietotekniikka), I guess Finnish notation does depend a bit on if 2^10 or 10^3 are used for the units? Glanced at the patch code didn't clear this up at all, but I guess it uses the 2^10*x since you included i in the translations… If it's that
(2^10/2^20/etc) should be KiB, MiB, etc.

@l-2-j l-2-j changed the title Update Finnish storage unit translations Fix unit translations a negated sign & Finnish issues May 21, 2025
@Banane9
Copy link
Contributor

Banane9 commented May 21, 2025

but I guess it uses the 10^x since you included i in the translations… If it's that
(2^10/2^20/etc) should be KiB, MiB, etc.

it's the opposite way, kibi, gibi, etc. are 1024

@l-2-j l-2-j force-pushed the fi-storage-units branch from 0e166d0 to b8a2647 Compare May 21, 2025 21:09
@l-2-j l-2-j changed the title Fix unit translations a negated sign & Finnish issues Fix unit translations Finnish issues & cleanup May 21, 2025
@l-2-j l-2-j changed the title Fix unit translations Finnish issues & cleanup Fix unit translations Finnish issue May 21, 2025
@l-2-j l-2-j force-pushed the fi-storage-units branch from b8a2647 to 27072c5 Compare May 21, 2025 21:37
@l-2-j l-2-j changed the title Fix unit translations Finnish issue Bytes formatting IEC/Decimals option May 21, 2025
@l-2-j l-2-j force-pushed the fi-storage-units branch from 4759bf0 to 5aeec0f Compare May 21, 2025 23:54
@Banane9 Banane9 merged commit 7bf5a7b into master May 22, 2025
2 checks passed
@Banane9 Banane9 deleted the fi-storage-units branch May 22, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants