Add custom base Monkey type #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nytra
reviewed
Jun 3, 2025
| [HarmonyPatchCategory(nameof(ValueModDecimal))] | ||
| [HarmonyPatch(typeof(Elements.Core.Coder<Decimal>), nameof(Elements.Core.Coder<Decimal>.Mod))] | ||
| internal sealed class ValueModDecimal : ResoniteMonkey<ValueModDecimal> | ||
| [HarmonyPatch(typeof(Coder<decimal>), nameof(Coder<Decimal>.Mod))] |
Contributor
There was a problem hiding this comment.
different casing for decimal vs Decimal, not sure if this causes issues?
Contributor
Author
There was a problem hiding this comment.
decimal is just a C# alias for System.Decimal - I just changed it for consistency, not sure why it got in differently 😅
Contributor
Author
There was a problem hiding this comment.
And oh, I see what you mean now, one is still capitalized... Huh
Contributor
There was a problem hiding this comment.
I think it should be fine, in the decompiler they both point to the same type
Contributor
Author
There was a problem hiding this comment.
Yea, not worried about that, I just want it consistent 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom ResoniteBugFixMonkey base type for the fixes that handles some basics like making the BugFixOptions available in all of them