-
Notifications
You must be signed in to change notification settings - Fork 53
Minor change to leaderboards.md: Clarification of game speed hint #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove confusing part of sentence
|
The missing note below was probably documenting the formats, which now live here (see the notes below the table).
The issue the comment is trying to address is that using the FRAMES format always divides by 60 even if your game is running at 50fps (or even something else like 30fps). |
|
After reading through the page again, I think I found what was meant: a note, maybe the one at the subchapter Value Format:
Not sure if a direct link to that paragraph can be added? There are several "note"s inbetween, so the reference to "not(e) below" is confusing. |
|
@Jamiras Good point, so the comment should stay in some form. I think the note on Value Format is even more fitting? I'll update the PR later this evening to reference to it. |
Clarify the frame rate context for the leaderboard type.
Updated link in the Type section for clarity.
|
Updated PR:
|
|
@Jamiras What do you think of the edited PR? |
Jamiras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes address the previous problems. I've left a couple comments, but will leave final approval to someone more versed in managing the documentation repository.
| The **Title/Description** fields are quite obvious. | ||
|
|
||
| The **Type** is "Time (Frames)". The value we're tracking updates once a frame, and the Genesis runs at 60 frames per second. (see not below for systems that run at other speeds) | ||
| The **Type** is "Time (Frames)". The value we're tracking updates once a frame, and the Genesis runs at 60 frames per second (see note below on [Value Format](/developer-docs/leaderboards#value-format) for systems that run at other speeds). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual URL is https://docs.retroachievements.org/developer-docs/leaderboards.html#value-format. I don't know if the ".html" is implied and will be added by the conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit leary about saying "see note below" when it's the note on the linked document. Maybe just "see note on...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual URL is https://docs.retroachievements.org/developer-docs/leaderboards.html#value-format. I don't know if the ".html" is implied and will be added by the conversion.
The style link he has will get built to the right url when it's built and deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit leary about saying "see note below" when it's the note on the linked document. Maybe just "see note on...".
The link is to a paragraph far down below, but still on the same page (leaderboards.html), that's why I kept the below (which was there originally). But it can also be removed if it doesn't fit.
Edit: Instead of removing the part, I suggest to improve it, see my latest comment below.
Original comment:
Remove confusing part of sentence.
I really struggled when reading the part I suggest to remove. What's the meaning of "see not below" - don't look below? Even if only the "not" was misplaced, there is nothing more below on the page about framerates or game speed.
I checked the Initial commit where this was added but was not able to find anything related to this.
Furthermore, a search across the RA docs with "framerate", "frame rate" or "game speed" does not return any page with additional information (except maybe for the
ResetIfdocs with a short note on PAL vs. NTSC, but I'm not sure if it's worth linking it).So my suggestion would be to remove this part of the sentence alltogether.