-
Notifications
You must be signed in to change notification settings - Fork 53
Move all external images to within the repo #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Good question. It's possible VitePress changed something in a recent update. I think we should probably:
|
|
@wescopeland So should I update the paths in this PR, or do we do this later? The change you suggest will also affect all other paths of existing And another question, how does the PR review process work, do I have to ping somewhere or will it get picked up eventually by somebody? |
Move all images from external sources to this repository.
Solves the following issue: #158
Some notes:
camo.githubusercontent.comwere not accessible directly anymore, so I used the images provided by archive.org (Example)memsizes.png=>mem-inspector-size-diagram.png, images onmemory-inspector.md(memoryinspector-num.png,memoryinspector-filter.png,memoryinspector-bookmark.pngetc.)-), some underscores (_) were replaced.alttext to the images where missing, and tried to replace genericdescriptions with something more meaningful. I did not fix all existingalttexts, they are not all aligned currently, but I focussed on the image replacements.docs/guidelines/content/hash-labels.md(yet) - I was hesitant if those should be duplicated to this repo, as they are referenced directly (and used as image tags) from all the "Supported Game Files" pages. If they should also be included here please let me know. (I did update the image links in theptversion, there was an update to the image links in the English version which was not applied inpt).rabot-*.pngfor the Discord RA Bot page. If I get it correctly a flat directory structure ofpublicis desirable, so I didn't create subfolders.❓Question: When running the docs locally, I got warnings:
But the
contributing-to-the-docs.htmlexplicitly states to use image links with the/publicprefix:Can the local warnings be ignored?