Skip to content

Add solution for Challenge 3 by baindraraj #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Add solution for Challenge 3 by baindraraj #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions challenge-3/submissions/baindraraj/solution-template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
package main

import "fmt"

type Employee struct {
ID int
Name string
Age int
Salary float64
}

type Manager struct {
Employees []Employee
}

// AddEmployee adds a new employee to the manager's list.
func (m *Manager) AddEmployee(e Employee) {
// TODO: Implement this method
m.Employees = append(m.Employees, e)
}
Comment on lines +16 to +20
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove TODO comment.

The method is implemented correctly, but the TODO comment on Line 18 should be removed.

-	// TODO: Implement this method
 	m.Employees = append(m.Employees, e)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// AddEmployee adds a new employee to the manager's list.
func (m *Manager) AddEmployee(e Employee) {
// TODO: Implement this method
m.Employees = append(m.Employees, e)
}
// AddEmployee adds a new employee to the manager's list.
func (m *Manager) AddEmployee(e Employee) {
m.Employees = append(m.Employees, e)
}
🤖 Prompt for AI Agents 
In challenge-3/submissions/baindraraj/solution-template.go around lines 16 to
20, remove the leftover TODO comment on line 18 since the AddEmployee method is
implemented correctly; simply delete the "// TODO: Implement this method" line
so the function contains only the implementation and any needed comments
describing behavior.


// RemoveEmployee removes an employee by ID from the manager's list.
func (m *Manager) RemoveEmployee(id int) {
// TODO: Implement this method
for indx, e := range m.Employees {
if e.ID == id {
m.Employees = append(m.Employees[:indx], m.Employees[indx+1:]...)
break
}
}
}
Comment on lines +22 to +31
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove TODO comment.

The method is implemented correctly, but the TODO comment on Line 24 should be removed.

-	// TODO: Implement this method
 	for indx, e := range m.Employees {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// RemoveEmployee removes an employee by ID from the manager's list.
func (m *Manager) RemoveEmployee(id int) {
// TODO: Implement this method
for indx, e := range m.Employees {
if e.ID == id {
m.Employees = append(m.Employees[:indx], m.Employees[indx+1:]...)
break
}
}
}
// RemoveEmployee removes an employee by ID from the manager's list.
func (m *Manager) RemoveEmployee(id int) {
for indx, e := range m.Employees {
if e.ID == id {
m.Employees = append(m.Employees[:indx], m.Employees[indx+1:]...)
break
}
}
}
🤖 Prompt for AI Agents 
In challenge-3/submissions/baindraraj/solution-template.go around lines 22 to
31, remove the TODO comment on line 24 because the RemoveEmployee method is
already implemented; delete the "// TODO: Implement this method" line so the
comment no longer incorrectly indicates incomplete work and leave the
implemented loop and logic intact.


// GetAverageSalary calculates the average salary of all employees.
func (m *Manager) GetAverageSalary() float64 {
// TODO: Implement this method
if len(m.Employees) == 0 {
return 0
}

var total float64
cnt := 0
for _, e := range m.Employees {
total += e.Salary
cnt++
}

return total/ float64(cnt)
}
Comment on lines +33 to +48
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove TODO comment and simplify logic.

The method works correctly but has a few minor issues:

  • Line 35: TODO comment should be removed
  • Line 47: Missing space before / operator
  • Lines 41-44: The cnt variable is redundant since len(m.Employees) is already known
-	// TODO: Implement this method
 	if len(m.Employees) == 0 {
 	    return 0
 	}
 	
 	var total float64
-	cnt := 0
 	for _, e := range m.Employees {
 	    total += e.Salary
-	    cnt++
 	}
 	
-	return total/ float64(cnt)
+	return total / float64(len(m.Employees))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// GetAverageSalary calculates the average salary of all employees.
func (m *Manager) GetAverageSalary() float64 {
// TODO: Implement this method
if len(m.Employees) == 0 {
return 0
}
var total float64
cnt := 0
for _, e := range m.Employees {
total += e.Salary
cnt++
}
return total/ float64(cnt)
}
// GetAverageSalary calculates the average salary of all employees.
func (m *Manager) GetAverageSalary() float64 {
if len(m.Employees) == 0 {
return 0
}
var total float64
for _, e := range m.Employees {
total += e.Salary
}
return total / float64(len(m.Employees))
}
🤖 Prompt for AI Agents 
In challenge-3/submissions/baindraraj/solution-template.go around lines 33 to
48, remove the TODO comment, eliminate the redundant cnt variable and use
len(m.Employees) directly, and fix spacing by adding a space before the division
operator so the return becomes total / float64(len(m.Employees)); keep the
empty-slice check returning 0 as-is.


// FindEmployeeByID finds and returns an employee by their ID.
func (m *Manager) FindEmployeeByID(id int) *Employee {
// TODO: Implement this method
for _, e := range m.Employees {
if e.ID == id {
return &e
}
}
return nil
}
Comment on lines +50 to +59
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical bug: returning address of loop variable.

Line 55 returns &e, where e is the range loop variable. In Go, the loop variable is reused in each iteration, so its address remains constant. This means &e will point to the memory location of the loop variable, not the actual employee in the slice. After the loop, this address may contain the last iterated value or be in an undefined state.

-	// TODO: Implement this method
-	for _, e := range m.Employees {
+	for i := range m.Employees {
+	    e := &m.Employees[i]
 	    if e.ID == id {
-	        return &e
+	        return e
 	    }
 	}
 	return nil
🤖 Prompt for AI Agents 
In challenge-3/submissions/baindraraj/solution-template.go around lines 50 to
59, the method currently returns &e where e is the range loop variable — fix by
returning the address of the actual slice element instead of the loop variable;
iterate with index (for i := range m.Employees) or use for i, e := range
m.Employees and return &m.Employees[i] when IDs match so the pointer refers to
the real Employee in the slice.


func main() {
manager := Manager{}
manager.AddEmployee(Employee{ID: 1, Name: "Alice", Age: 30, Salary: 70000})
manager.AddEmployee(Employee{ID: 2, Name: "Bob", Age: 25, Salary: 65000})
manager.RemoveEmployee(1)
averageSalary := manager.GetAverageSalary()
employee := manager.FindEmployeeByID(2)

fmt.Printf("Average Salary: %f\n", averageSalary)
if employee != nil {
fmt.Printf("Employee found: %+v\n", *employee)
}
}
Loading