Add solution for Challenge 2 by AlexandrZlnov

[AlexandrZlnov]

No description provided.

[coderabbitai]

Walkthrough

Adds three Go submission programs: challenge-1 adds Sum(a, b) int with a main that parses two integers; challenge-2 adds ReverseString(s string) that reverses Unicode runes with a main that reads and prints a line; challenge-3 adds Employee and Manager types with Add/Remove/Find/GetAverageSalary and a demo main.

Changes

Cohort / File(s)	Summary
Challenge 1 Solution challenge-1/submissions/AlexandrZlnov/solution-template.go	Adds Sum(a int, b int) int returning a + b. Adds main that parses two integers from stdin using format "%d, %d", calls Sum, and prints the result.
Challenge 2 Solution challenge-2/submissions/AlexandrZlnov/solution-template.go	Adds ReverseString(s string) string which reverses Unicode code points by converting to a []rune and swapping in place. Adds main that reads a line via scanner, calls ReverseString, and prints the reversed string.
Challenge 3 Solution challenge-3/submissions/AlexandrZlnov/solution-template.go	Introduces Employee and Manager types (Employees []Employee). Adds methods AddEmployee(e Employee), RemoveEmployee(id int) (uses slices.Delete), GetAverageSalary() float64 (returns 0 if none; computes average over Salary fields), and FindEmployeeByID(id int) *Employee. Adds a main demonstrating usage and imports fmt and slices.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Main as main (challenge-2)
    participant Reverse as ReverseString
    User->>Main: provide input line (stdin)
    Main->>Reverse: ReverseString(input)  -- uses []rune swap
    Reverse-->>Main: reversed string
    Main-->>User: print reversed string (stdout)

Loading

sequenceDiagram
    participant User
    participant Main as main (challenge-1)
    participant Sum as Sum
    User->>Main: provide "int, int" (stdin)
    Main->>Sum: Sum(a, b)
    Sum-->>Main: a + b
    Main-->>User: print sum (stdout)

Loading

sequenceDiagram
    participant Caller
    participant Manager
    Caller->>Manager: AddEmployee(e)
    Manager-->>Manager: append employee
    Caller->>Manager: RemoveEmployee(id)
    Manager-->>Manager: find index, slices.Delete(...)
    Caller->>Manager: GetAverageSalary()
    Manager-->>Manager: sum salaries / count (returns 0 if none)
    Manager-->>Caller: average (float64)
    Caller->>Manager: FindEmployeeByID(id)
    Manager-->>Caller: *Employee or nil

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Add solution for Challenge 2 by Kosench #560 — Adds a Challenge-2 submission that defines the same exported ReverseString(s string) string.
• Add solution for Challenge 1 by redstrike #595 — Adds an exported Sum(a int, b int) int in a Challenge-1 submission (same function and file area).
• Add solution for Challenge 3 by Kosench #561 — Adds a Challenge-3 implementation introducing Employee and Manager types and the same manager methods (AddEmployee, RemoveEmployee, GetAverageSalary, FindEmployeeByID).

Pre-merge checks

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The pull request title states "Add solution for Challenge 2 by AlexandrZlnov," but the changeset actually includes solutions for three challenges: Challenge 1 (Sum function), Challenge 2 (ReverseString function), and Challenge 3 (Employee Management utilities). While the title correctly identifies that a Challenge 2 solution is being added, it is misleading about the actual scope of the pull request, suggesting only Challenge 2 is included when the PR covers three separate challenge solutions. This incomplete representation makes the title misleading about what is actually being merged.
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check	❓ Inconclusive	The author did not provide any pull request description for this submission. Without a description present, there is no content to evaluate for relatedness to the changeset. The absence of a description creates ambiguity: while it is not actively unrelated or off-topic (as it contains no information at all), it also does not satisfy the pass criterion of being "related in some way to the changeset," since nothing is stated. This edge case falls outside the clear boundaries established by the pass/fail criteria.	While this check is lenient, adding a description would improve clarity. Consider providing at least a brief summary explaining the purpose of the submission, such as mentioning that it contains solutions for three coding challenges with their respective implementations.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e02ed4 and 2822645.

📒 Files selected for processing (1)

• challenge-3/submissions/AlexandrZlnov/solution-template.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• challenge-3/submissions/AlexandrZlnov/solution-template.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

challenge-2/submissions/AlexandrZlnov/solution-template.go (1)

9-21: Add error handling for scanner.

The scanner may encounter errors during input reading that won't be detected. After the scan loop, check for errors to ensure robust I/O handling.

Apply this diff to add error handling:

 func main() {
 	// Read input from standard input
 	scanner := bufio.NewScanner(os.Stdin)
 	if scanner.Scan() {
 		input := scanner.Text()
 
 		// Call the ReverseString function
 		output := ReverseString(input)
 
 		// Print the result
 		fmt.Println(output)
 	}
+	if err := scanner.Err(); err != nil {
+		fmt.Fprintf(os.Stderr, "Error reading input: %v\n", err)
+		os.Exit(1)
+	}
 }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ebd0bb3 and 1f8fa2f.

📒 Files selected for processing (1)

• challenge-2/submissions/AlexandrZlnov/solution-template.go (1 hunks)

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

challenge-1/submissions/AlexandrZlnov/solution-template.go (1)

7-19: Logic is correct; consider stderr for errors.

The main function correctly reads input, handles errors, and produces output. For better practice, error messages could be written to stderr using fmt.Fprintln(os.Stderr, ...) and the program could exit with a non-zero status.

Optional improvement:

+import (
+	"fmt"
+	"os"
+)
+
 func main() {
 	var a, b int
 	// Read two integers from standard input
 	_, err := fmt.Scanf("%d, %d", &a, &b)
 	if err != nil {
-		fmt.Println("Error reading input:", err)
-		return
+		fmt.Fprintln(os.Stderr, "Error reading input:", err)
+		os.Exit(1)
 	}

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f8fa2f and 959a2cf.

📒 Files selected for processing (1)

• challenge-1/submissions/AlexandrZlnov/solution-template.go (1 hunks)

🔇 Additional comments (1)

challenge-1/submissions/AlexandrZlnov/solution-template.go (1)

1-5: LGTM!

Package declaration and imports are appropriate for this solution.

[coderabbitai]

Actionable comments posted: 4

🧹 Nitpick comments (1)

challenge-3/submissions/AlexandrZlnov/solution-template.go (1)

3-6: Minor formatting inconsistency.

Extra whitespace before the closing parenthesis on line 6.

 import (
     "fmt"
     "slices"
-    )
+)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 959a2cf and ab49281.

📒 Files selected for processing (1)

• challenge-3/submissions/AlexandrZlnov/solution-template.go (1 hunks)

🔇 Additional comments (2)

challenge-3/submissions/AlexandrZlnov/solution-template.go (2)

8-17: LGTM!

The struct definitions are clean and well-structured for an employee management system.

---

70-82: Demo logic is sound.

The main function appropriately demonstrates the Manager's methods. Once the critical issues in GetAverageSalary and FindEmployeeByID are resolved, this will work correctly.