Skip to content

Add solution for Challenge 2 by iamsurajmandal #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

Add solution for Challenge 2 by iamsurajmandal #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions challenge-2/submissions/iamsurajmandal/solution-template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package main

import (
"bufio"
"fmt"
"os"
)

func main() {
// Read input from standard input
scanner := bufio.NewScanner(os.Stdin)
if scanner.Scan() {
input := scanner.Text()

// Call the ReverseString function
output := ReverseString(input)

// Print the result
fmt.Println(output)
}
}
Comment on lines +9 to +21
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add error handling for scanner.

The code doesn't check for scanner errors after reading input. If scanner.Scan() returns false, it could be due to EOF (expected) or an error (unexpected).

Apply this diff to add proper error handling:

 func main() {
 	// Read input from standard input
 	scanner := bufio.NewScanner(os.Stdin)
 	if scanner.Scan() {
 		input := scanner.Text()
 
 		// Call the ReverseString function
 		output := ReverseString(input)
 
 		// Print the result
 		fmt.Println(output)
 	}
+	if err := scanner.Err(); err != nil {
+		fmt.Fprintf(os.Stderr, "Error reading input: %v\n", err)
+		os.Exit(1)
+	}
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
func main() {
// Read input from standard input
scanner := bufio.NewScanner(os.Stdin)
if scanner.Scan() {
input := scanner.Text()
// Call the ReverseString function
output := ReverseString(input)
// Print the result
fmt.Println(output)
}
}
func main() {
// Read input from standard input
scanner := bufio.NewScanner(os.Stdin)
if scanner.Scan() {
input := scanner.Text()
// Call the ReverseString function
output := ReverseString(input)
// Print the result
fmt.Println(output)
}
if err := scanner.Err(); err != nil {
fmt.Fprintf(os.Stderr, "Error reading input: %v\n", err)
os.Exit(1)
}
}
🤖 Prompt for AI Agents 
In challenge-2/submissions/iamsurajmandal/solution-template.go around lines 9 to
21, the main function calls scanner.Scan() but does not handle the case where
Scan returns false due to an error; update the code to always check
scanner.Err() after the Scan loop (or after the single Scan) and if err != nil
write a clear error message to stderr and exit non‑zero, while keeping normal
behavior for EOF/empty input (no error). Ensure you return/exit after reporting
the error so the program does not continue as if input succeeded.


// ReverseString returns the reversed string of s.
func ReverseString(s string) string {
runeString := []rune(s)
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix indentation and remove unnecessary semicolon.

Lines 25 and 27 use spaces for indentation instead of tabs, and line 27 has an unnecessary semicolon. Go convention is to use tabs for indentation and avoid semicolons at the end of statements.

Run gofmt to automatically fix formatting:

gofmt -w challenge-2/submissions/iamsurajmandal/solution-template.go

Also applies to: 27-27

🤖 Prompt for AI Agents 
challenge-2/submissions/iamsurajmandal/solution-template.go lines 25 and 27: the
indentation on these lines uses spaces instead of tabs and line 27 ends with an
unnecessary semicolon; fix by replacing the leading spaces with a single tab on
each affected line, remove the trailing semicolon from line 27, then run `gofmt
-w challenge-2/submissions/iamsurajmandal/solution-template.go` to apply Go
formatting conventions automatically.

for i, j := 0, len(runeString) - 1; i < j; i, j = i + 1, j - 1 {
temp := runeString[i];
runeString[i] = runeString[j]
runeString[j] = temp
}
return string(runeString)
}
Loading