Add solution for Challenge 1 by kiramux

[kiramux]

Challenge 1 Solution

Submitted by: @kiramux
Challenge: Challenge 1

Description

This PR contains my solution for Challenge 1.

Changes

• Added solution file to challenge-1/submissions/kiramux/solution-template.go

Testing

• Solution passes all test cases
• Code follows Go best practices

Thank you for reviewing my submission! 🚀

[coderabbitai]

Walkthrough

Adds a new Go solution at challenge-1/submissions/kiramux/solution-template.go that reads two comma-separated integers from stdin with fmt.Scanf, computes their sum via a new exported Sum(a int, b int) int, handles input errors, and prints the result.

Changes

Cohort / File(s)	Change Summary
Challenge 1 submission challenge-1/submissions/kiramux/solution-template.go	New file: main reads two ints using fmt.Scanf("%d, %d"), checks for scan errors, calls exported Sum(a int, b int) int, and prints the sum. Implements Sum returning a + b.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant User
    participant Main as main()
    participant SumFn as Sum(a,b)

    Note over User,Main: program start
    User->>Main: provide input "x, y"
    Main->>Main: fmt.Scanf("%d, %d") -> a, b
    alt scan success
        Main->>SumFn: Sum(a,b)
        SumFn-->>Main: return a+b
        Main->>User: fmt.Println(sum)
    else scan error
        Main->>User: fmt.Println("error reading input")
    end

Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Potential review focus:

• Correctness of fmt.Scanf format and error handling.
• Exported function name and signature (Sum(a int, b int) int).

Possibly related PRs

• Add solution for Challenge 1 by redstrike #595 — Adds an identical exported Sum(a int, b int) int and similar solution-template.go input/print logic.
• Add solution for Challenge 1 by Kosench #559 — Adds the same Sum function and near-identical main that reads two ints and prints their sum.
• Add solution for Challenge 1 by fzzv #634 — Adds an identical Challenge 1 solution file defining Sum and using fmt.Scanf("%d, %d") in main.

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a Challenge 1 solution submission by the user kiramux.
Description check	✅ Passed	The description is directly related to the changeset, clearly describing the Challenge 1 solution submission with file path and testing verification.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a736891 and 9c8f260.

📒 Files selected for processing (1)

• challenge-1/submissions/kiramux/solution-template.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• challenge-1/submissions/kiramux/solution-template.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

challenge-1/submissions/kiramux/solution-template.go (2)

10-14: Consider improving error handling to follow Go best practices.

The error handling could be enhanced:

1. Error messages should be written to os.Stderr instead of fmt.Println (which writes to stdout).
2. The program should exit with a non-zero status code to signal failure.

Apply this diff to improve error handling:

+import (
+	"fmt"
+	"os"
+)
+
 func main() {
 	var a, b int
 	// Read two integers from standard input
 	_, err := fmt.Scanf("%d, %d", &a, &b)
 	if err != nil {
-		fmt.Println("Error reading input:", err)
-		return
+		fmt.Fprintf(os.Stderr, "Error reading input: %v\n", err)
+		os.Exit(1)
 	}

---

22-22: Consider using Go's parameter shorthand syntax.

When consecutive parameters share the same type, Go allows the shorthand Sum(a, b int) instead of Sum(a int, b int). This is more idiomatic and concise.

Apply this diff:

-func Sum(a int, b int) int {
+func Sum(a, b int) int {

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between accf97c and a736891.

📒 Files selected for processing (1)

• challenge-1/submissions/kiramux/solution-template.go (1 hunks)

🔇 Additional comments (1)

challenge-1/submissions/kiramux/solution-template.go (1)

1-5: LGTM!

The package declaration and imports are clean and appropriate for a simple executable program.

[kiramux]

remove todo comment