Add solution for Challenge 2 by kiramux #729
Conversation
WalkthroughAdds a new Go submission file that implements a string reversal function using a two-pointer byte-swap approach. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
challenge-2/submissions/kiramux/solution-template.go(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
challenge-2/submissions/kiramux/solution-template.go (1)
challenge-2/submissions/0xarash/solution-template.go (1)
ReverseString(24-31)
| scanner := bufio.NewScanner(os.Stdin) | ||
| if scanner.Scan() { | ||
| input := scanner.Text() | ||
|
|
||
| // Call the ReverseString function | ||
| output := ReverseString(input) | ||
|
|
||
| // Print the result | ||
| fmt.Println(output) | ||
| } |
There was a problem hiding this comment.
Check for scanner errors after reading input.
The scanner may encounter errors while reading from stdin. After scanner.Scan() returns false, you should check scanner.Err() to distinguish between EOF and actual errors.
Apply this diff to add error handling:
scanner := bufio.NewScanner(os.Stdin)
if scanner.Scan() {
input := scanner.Text()
// Call the ReverseString function
output := ReverseString(input)
// Print the result
fmt.Println(output)
}
+ if err := scanner.Err(); err != nil {
+ fmt.Fprintln(os.Stderr, "Error reading input:", err)
+ os.Exit(1)
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| scanner := bufio.NewScanner(os.Stdin) | |
| if scanner.Scan() { | |
| input := scanner.Text() | |
| // Call the ReverseString function | |
| output := ReverseString(input) | |
| // Print the result | |
| fmt.Println(output) | |
| } | |
| scanner := bufio.NewScanner(os.Stdin) | |
| if scanner.Scan() { | |
| input := scanner.Text() | |
| // Call the ReverseString function | |
| output := ReverseString(input) | |
| // Print the result | |
| fmt.Println(output) | |
| } | |
| if err := scanner.Err(); err != nil { | |
| fmt.Fprintln(os.Stderr, "Error reading input:", err) | |
| os.Exit(1) | |
| } |
🤖 Prompt for AI Agents
In challenge-2/submissions/kiramux/solution-template.go around lines 11 to 20,
the code calls scanner.Scan() but does not check scanner.Err() afterwards;
update the code so that after the Scan attempt you call scanner.Err() and if it
returns a non-nil error print a descriptive message to stderr (or log) and exit
with a non-zero status to signal failure, otherwise proceed normally (nil error
implies EOF/no input). Ensure the error handling runs when Scan() returns false
so real I/O errors are distinguished from EOF.
| func ReverseString(s string) string { | ||
| if len(s) == 0 { | ||
| return "" | ||
| } | ||
| str := []byte(s) | ||
| left := 0 | ||
| right := len(str) - 1 | ||
| for left < right { | ||
| str[left], str[right] = str[right], str[left] | ||
| left++ | ||
| right-- | ||
| } | ||
| return string(str) | ||
| } |
There was a problem hiding this comment.
Use []rune instead of []byte to correctly handle Unicode characters.
The current implementation converts the string to []byte, which reverses raw bytes rather than Unicode characters. This will corrupt multi-byte UTF-8 characters like emojis, Chinese characters, accented letters, etc.
For example:
- Input:
"Hello, 世界" - Expected:
"界世 ,olleH" - Actual with
[]byte: Mangled output with broken UTF-8 sequences
Apply this diff to fix the Unicode handling:
func ReverseString(s string) string {
- if len(s) == 0 {
- return ""
- }
- str := []byte(s)
- left := 0
- right := len(str) - 1
- for left < right {
- str[left], str[right] = str[right], str[left]
- left++
- right--
+ r := []rune(s)
+ for i, j := 0, len(r)-1; i < j; i, j = i+1, j-1 {
+ r[i], r[j] = r[j], r[i]
}
- return string(str)
+ return string(r)
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| func ReverseString(s string) string { | |
| if len(s) == 0 { | |
| return "" | |
| } | |
| str := []byte(s) | |
| left := 0 | |
| right := len(str) - 1 | |
| for left < right { | |
| str[left], str[right] = str[right], str[left] | |
| left++ | |
| right-- | |
| } | |
| return string(str) | |
| } | |
| func ReverseString(s string) string { | |
| r := []rune(s) | |
| for i, j := 0, len(r)-1; i < j; i, j = i+1, j-1 { | |
| r[i], r[j] = r[j], r[i] | |
| } | |
| return string(r) | |
| } |
🤖 Prompt for AI Agents
In challenge-2/submissions/kiramux/solution-template.go around lines 24 to 37,
the function reverses raw bytes using []byte which corrupts multi-byte UTF-8
characters; change the implementation to convert the string to []rune, perform
the in-place two-pointer swap on runes, then return string(runes) so Unicode
characters (emojis, CJK, accented letters) are handled correctly.
2 participants
Challenge 2 Solution
Submitted by: @kiramux
Challenge: Challenge 2
Description
This PR contains my solution for Challenge 2.
Changes
challenge-2/submissions/kiramux/solution-template.goTesting
Thank you for reviewing my submission! 🚀